Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable no-unsafe-values and add it to recommended configuration #51

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Enables no-unsafe-values rule to be used.

What changes did you make? (Give an overview)

Added the rule to plugin.rules, recommended configuration and README.

Related Issues

Follow up to #30.

Is there anything you'd like reviewers to focus on?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you! We probably need some kind of automation to check for these types of errors.

@nzakas nzakas merged commit 72273f5 into main Nov 7, 2024
15 checks passed
@nzakas nzakas deleted the enable-no-unsafe-values branch November 7, 2024 22:17
@mdjermanovic
Copy link
Member Author

mdjermanovic commented Nov 8, 2024

We probably need some kind of automation to check for these types of errors.

Here are tests that should catch this: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants