Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump mdast-util-from-markdown with synckit #229

Closed
wants to merge 1 commit into from

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Dec 1, 2023

close #218, drop node 12

mdast-util-from-markdown is ESM only now, synckit makes it possible to require ESM only module in commonjs without await import().

cc @btmills @nzakas

@JounQin JounQin changed the title feat!: bump with mdast-util-from-markdown with synckit feat!: bump mdast-util-from-markdown with synckit Dec 1, 2023
@nzakas
Copy link
Member

nzakas commented Dec 12, 2023

We don't want to drop Node 12 until we release ESLint v9, which will also drop Node.js 12.

Is there a reason we can't use mdast-util-from-markdown 0.8.5 for now?

@JounQin
Copy link
Contributor Author

JounQin commented Dec 12, 2023

It requires outdated unified related packages may results conflict/duplicate dependencies.

@nzakas
Copy link
Member

nzakas commented Dec 13, 2023

Okay, We'll still need to wait until ESLint v9 to drop Node.js 12 support. At that point, we need to update Node.js support for all packages.

@JounQin
Copy link
Contributor Author

JounQin commented Dec 13, 2023

@nzakas

image

[email protected] supports Node 12, would that be acceptable? I can patch Node v12 support back on v0.8 either.

@JounQin
Copy link
Contributor Author

JounQin commented Dec 22, 2023

Friendly ping @nzakas

@nzakas
Copy link
Member

nzakas commented Jan 4, 2024

We just released ESLint v9.0.0-alpha, so I think we can formally update the Node.js support for this package now.

Can you submit a PR like this? eslint/eslint-scope#115

@JounQin
Copy link
Contributor Author

JounQin commented Jan 5, 2024

@nzakas

Wow, that's really a big change, I was thinking to keep compatible, not ESLint v9 only. Because in case the big breaking changes on eslint v9, I believe the migration could be very slow.

@JounQin
Copy link
Contributor Author

JounQin commented Jan 22, 2024

@nzakas Any further discussion?

@aladdin-add
Copy link
Member

@JounQin it has dropped node.js < 18 supports. what's the next steps here?

@JounQin
Copy link
Contributor Author

JounQin commented Apr 19, 2024

@aladdin-add Didn't notice that, I've updated the PR accordingly.

@nzakas
Copy link
Member

nzakas commented Apr 22, 2024

At this point, I don't think we should move further with this PR. It's not fixing any bugs and adding in a new dependency just to upgrade some other module doesn't seem like a good tradeoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: update dependencies
4 participants