fix: correct the return type of applyInlineConfig

[lumirlumir]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

Which language are you using?

CommonMark and GFM.

What did you do?

I expected the return type of applyInlineConfig().configs — specifically loc.start and loc.end — to include an offset property, but they don't.

What did you expect to happen?

I expect the types of loc.start and loc.end to include an offset property.

Link to minimal reproducible Example

import { MarkdownSourceCode } from "./src/index.js";

const markdownSourceCode = new MarkdownSourceCode({
	text: '<!-- eslint markdown/no-html: "error" -->',
	ast: {
		type: "root",
		children: [
			{
				type: "html",
				value: '<!-- eslint markdown/no-html: "error" -->',
				position: {
					start: {
						line: 1,
						column: 1,
						offset: 0,
					},
					end: {
						line: 1,
						column: 42,
						offset: 41,
					},
				},
			},
		],
		position: {
			start: {
				line: 1,
				column: 1,
				offset: 0,
			},
			end: {
				line: 1,
				column: 42,
				offset: 41,
			},
		},
	},
});

console.log(markdownSourceCode.applyInlineConfig().configs[0].loc);

If you run the code above, you'll see that markdownSourceCode.applyInlineConfig().configs[0].loc.start and markdownSourceCode.applyInlineConfig().configs[0].loc.end include an offset property. However, the return type doesn't reflect that offset property.

# Output
{
  start: { line: 1, column: 1, offset: 0 },
  end: { line: 1, column: 42, offset: 41 }
}

What changes did you make? (Give an overview)

Looking at the origin of the loc property returned by applyInlineConfig, you'll find that it directly uses the position property of the Html node.

markdown/src/language/markdown-source-code.js

Lines 83 to 85 in 88b9391

	const start = {
	...node.position.start,
	};

markdown/src/language/markdown-source-code.js

Line 98 in 88b9391

start.offset += match.index;

markdown/src/language/markdown-source-code.js

Lines 87 to 89 in 88b9391

	const end = {
	...node.position.start,
	};

markdown/src/language/markdown-source-code.js

Line 107 in 88b9391

end.offset = start.offset + comment.length;

markdown/src/language/markdown-source-code.js

Lines 112 to 115 in 88b9391

	position: {
	start,
	end,
	},

The position property uses the Position type from unist as shown below, so technically it doesn’t match the SourceLocation type.

• Position

interface Position {
    start: {
        line: number;
        column: number;
        offset?: number | undefined;
    }
    end: {
        line: number;
        column: number;
        offset?: number | undefined;
    }
}

• SourceLocation

interface SourceLocation {
    start: {
        line: number;
        column: number;
    }
    end: {
        line: number;
        column: number;
    }
}

To provide a more accurate return type, I've replaced the SourceLocation type with the Position type from unist.

Related Issues

Ref: eslint/css#281, eslint/json#162

Is there anything you'd like reviewers to focus on?

N/A

[fasttime]

I can reproduce this. Marking as accepted.

[fasttime]

LGTM, thanks!