Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test in Bun #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: Test in Bun #87

wants to merge 2 commits into from

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 12, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add Bun CI testing

What changes did you make? (Give an overview)

  • Added GitHub workflow to run Bun
  • Made a small modification to a test in config-array because Bun has a different error message than in Node.js

Related Issues

Is there anything you'd like reviewers to focus on?

@nzakas
Copy link
Member Author

nzakas commented Jul 12, 2024

Not sure what's going on here. I can do bun run --bun build locally (Windows) and it works but seems to be failing in the CI.

@amareshsm
Copy link
Member

Not sure what's going on here. I can do bun run --bun build locally (Windows) and it works but seems to be failing in the CI.

In macOS, executing the bun run --bun build command within individual packages works correctly, but running it from the root directory results in the following error.
image

@nzakas
Copy link
Member Author

nzakas commented Jul 15, 2024

@amareshsm can you file a bug for Bun given that you can reproduce the problem locally?

@amareshsm
Copy link
Member

@amareshsm can you file a bug for Bun given that you can reproduce the problem locally?

Done.

@nzakas
Copy link
Member Author

nzakas commented Sep 3, 2024

Waiting for resolution on oven-sh/bun#12574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Implementing
Development

Successfully merging this pull request may close these issues.

2 participants