Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-498: Allow Panorama tour and single Panoramas to be overriden on all properties #499

Open
wants to merge 4 commits into
base: 1.5.0
Choose a base branch
from

Conversation

DiegoPino
Copy link
Member

@DiegoPino DiegoPino commented Mar 7, 2025

@roromedia this includes your commits too. I hope this aligns with your needs and also the other override options.

Using this you can now avoid the more complex override that used the media key, and go for overrides at the formatter/settings level using the new JS override

like

{
"mouseZoom": false
}

AND/Or at the Panorama Tour level like (RAW JSON of the TOUR itself)

"ap:viewerhints": {
        "strawberry_pannellum_formatter": {
            "author": "RoRO"
        }
    },

AND/OR at the individual Panoramas referenced from the tour (so at the Panorama ADO level/raw JSON) via

"ap:viewerhints": {
        "strawberry_pannellum_formatter": {
            "mouseZoom": true
        }
    },

And of course using as:formatter instead of "ap:viewerhints" and/or a $mediakey if you prefer that instead (which is not standard but I left it as a config option since this JS/PHP was the first one we extended before we made "ap:viewerhints" a global Viewer Override option)

Please test and let me know

This pull overrides #495 but includes your commits and also preserves your authorship/attribution.

Thanks

roromedia and others added 4 commits March 3, 2025 18:39
Settings are collected at the Panorama level and at the Tour level Cleaned and merged. This makes the settings easier. One can control/override at the Formatter level (settings per display mode), at the Panorama Tour level e.g
"ap:viewerhints": {
        "strawberry_pannellum_formatter": {
            "author": "Diego Pino",
            }
        }
    }

or add the panorama (ADO) object used in a tour, either by using that key,
or  the legacy
"ap:viewerhints": {
        "strawberry_pannellum_formatter": {
"urn:uuid:2f1b1a1f-ce8c-4522-9905-d3d51f49cefb": {
                "settings": {
                    "title": "testing override per media key"
                }
}
@DiegoPino DiegoPino self-assigned this Mar 7, 2025
@DiegoPino DiegoPino added enhancement New feature or request Javascript Favourite language of a PHP developer Field Formatter The thing that glues the pieces and adds glitter UI driven hints Show stuff on screen so people have less guessing to do UX Like UI but with an X labels Mar 7, 2025
@DiegoPino DiegoPino added this to the 1.5.0 milestone Mar 7, 2025
@DiegoPino DiegoPino changed the title ISSUE-498: Allow Panorama tour and single Panoramas to overriden on all properties ISSUE-498: Allow Panorama tour and single Panoramas to be overriden on all properties Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Field Formatter The thing that glues the pieces and adds glitter Javascript Favourite language of a PHP developer UI driven hints Show stuff on screen so people have less guessing to do UX Like UI but with an X
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants