Skip to content

Conversation

joshuacox
Copy link

Description

Adding esp32s3 XIAO pinout, and placing the pinouts in a separate header file in the hopes that someone else can utilize the same pinout header file in their project.

Related

possibly anyone with an esp32s3 xiao board who gets the Detected camera not supported error message.

Testing

I have one of these boards, and I did test with the definition changed at the top of take_picture.c:

#define BOARD_ESP32S3_XIAO

I can change that back if you like.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

…der file in the hopes that someone else can utilize the same pinout header file in their project

Signed-off-by: Joshua Edward McLaughlin Cox <[email protected]>
Signed-off-by: Joshua Edward McLaughlin Cox <[email protected]>
@@ -1,3 +1,3 @@
idf_component_register(SRCS take_picture.c
idf_component_register(SRCS take_picture.c camera_pinout.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed here.

// #define BOARD_WROVER_KIT
// #define BOARD_ESP32CAM_AITHINKER
// #define BOARD_ESP32S3_WROOM
//#define BOARD_ESP32S3_WROOM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

// #define BOARD_ESP32CAM_AITHINKER
// #define BOARD_ESP32S3_WROOM
//#define BOARD_ESP32S3_WROOM
#define BOARD_ESP32S3_XIAO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be commented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants