runplus: optimise UI rendering #3810
Merged
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timings for start/stop: 13:38:15.996Z: onStartStop() 13:38:16.006Z: setRecording() 13:38:16.728Z: setRecording() done 13:38:16.732Z: layout.render() 13:38:17.154Z: layout.render() done 13:38:17.157Z: exs.start/stop/resume() 13:38:17.161Z: exs.start/stop/resume() done 13:38:17.462Z: setStatus() 13:38:19.027Z: onStartStop() 13:38:19.199Z: exs.start/stop/resume() 13:38:19.202Z: exs.start/stop/resume() done 13:38:19.495Z: setStatus() 13:38:24.795Z: onStartStop() 13:38:24.805Z: setRecording() 13:38:25.483Z: setRecording() done 13:38:25.487Z: layout.render() 13:38:25.913Z: layout.render() done 13:38:25.915Z: exs.start/stop/resume() 13:38:25.919Z: exs.start/stop/resume() done 13:38:26.218Z: setStatus() 13:38:27.842Z: onStartStop() 13:38:28.010Z: exs.start/stop/resume() 13:38:28.012Z: exs.start/stop/resume() done 13:38:28.309Z: setStatus() in summary: setRecording: ~700ms layout.render(): ~420ms
|
Seems to work ok when I try it! Not sure what the functional change is just from a user perspective? It's not this PR's fault but i get in Web IDE: Maybe we change that in another PR later on. |
|
Thanks! Yes no functional change, just a slightly faster response when the user wants to start their run (if they don't have the recorder app installed). I'd notice it takes almost a second to draw, which doesn't give me confidence that runplus has started recording, but at the same time I don't want to be hanging about at the start line! So I've been attempting to speed things up (and agreed, r.e. another change for the deprecation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only redraw layout if we might've shown a setRecording prompt