-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[App Loader] Add dark mode support #4103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RKBoss6
wants to merge
12
commits into
espruino:master
Choose a base branch
from
RKBoss6:apploader-darkmode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−20
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
88d8521
Implement light-dark color scheme support
RKBoss6 56717a3
add a theme setting dropdown in settings page
RKBoss6 eec4865
Update submodule URL for EspruinoAppLoaderCore
RKBoss6 c1f6283
updated submodule test
RKBoss6 4cd2390
Update css/main.css
RKBoss6 7427058
Update css/main.css
RKBoss6 29f0d3a
Update css/main.css
RKBoss6 8d08499
Merge branch 'espruino:master' into apploader-darkmode
RKBoss6 0c8ede4
Change summary style for Advanced Options details
RKBoss6 7edc8f9
fix hero img not responding to theme changes
RKBoss6 e517ba4
Removing extra newlines, fixing indentation
gfwilliams b650fcf
Merge branch 'espruino:master' into apploader-darkmode
RKBoss6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| [submodule "EspruinoAppLoaderCore"] | ||
| path = core | ||
| url = https://github.com/espruino/EspruinoAppLoaderCore.git | ||
| url = https://github.com/RKBoss6/EspruinoAppLoaderCore.git | ||
| [submodule "webtools"] | ||
| path = webtools | ||
| url = https://github.com/espruino/EspruinoWebTools.git | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd need to back this out before we merge - although I know it's handy for testing at the moment