fix(tally): jump to settings when no tally types are configured - #4314
Merged
bobrippling merged 1 commit intoAug 17, 2026
Merged
Conversation
On first install (or after all tally types are removed), the app opened straight to an empty "Tallies" list with no way to tell the user what to do next - there was nothing to tally and no visible path to add a type. Check tallycfg.json before showing the list; if it's empty, load the app's own settings screen instead so the user can add a tally type right away. Fixes espruino#3853 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
Collaborator
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3853
On first install (or after removing all tally types), the app opened
straight to an empty "Tallies" list with no way to tell what to do next
— nothing to tally, and no visible path to add a type.
app.jsnow checkstallycfg.json(the configured tally types) beforeshowing the list; if it's empty, it loads the app's own settings screen
instead, using the same
eval(storage.read("<id>.settings.js"))(back)pattern already used elsewhere in this repo (e.g.
alarm,zambretti).Bumped to 0.03 with a ChangeLog entry.
Test plan
app.jsfromapp.tsvia the realtypescript/build.sh(
tsc), rather than hand-editing the compiled output.node bin/sanitycheck.js— 0 errors, 0 warnings (31 known/pre-existing errors and 13 known warnings elsewhere, unrelated).
npx eslint apps/tally --max-warnings 0— clean.available in my environment) — would appreciate a maintainer or
the reporter confirming the on-device behavior.