Skip to content

notify: only stopEventPropagation() in event handlers - #4332

Merged
gfwilliams merged 1 commit into
espruino:masterfrom
bobrippling:fix/notify-eventpropag
Sep 1, 2026
Merged

notify: only stopEventPropagation() in event handlers#4332
gfwilliams merged 1 commit into
espruino:masterfrom
bobrippling:fix/notify-eventpropag

Conversation

@bobrippling

Copy link
Copy Markdown
Collaborator

Closes #4327

@gfwilliams

Copy link
Copy Markdown
Member

Looks good to me! I think we just need to bump the version. Thanks!

@bobrippling
bobrippling force-pushed the fix/notify-eventpropag branch from e2106d1 to 08c3766 Compare August 31, 2026 16:22
@bobrippling

Copy link
Copy Markdown
Collaborator Author

Ah doh! Done

@gfwilliams

Copy link
Copy Markdown
Member

Great, thanks!

@gfwilliams
gfwilliams merged commit 12a5839 into espruino:master Sep 1, 2026
2 checks passed
@bobrippling
bobrippling deleted the fix/notify-eventpropag branch September 1, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[notify] Calling require("notify").hide() outside of an event handler crashes

2 participants