Skip to content

Include userAutoConfig in Auto Provider struct #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahrtr merged 2 commits into from
Jan 7, 2026
Merged

Include userAutoConfig in Auto Provider struct #255

ahrtr merged 2 commits into from
Jan 7, 2026

Conversation

@ArkaSaha30
Copy link
Contributor

@ArkaSaha30 ArkaSaha30 commented Dec 14, 2025 •
edited by ivanvc
Loading

This PR will refactor AutoCert Provider struct to include userAutoConfig.

Part of: #251

@ArkaSaha30 ArkaSaha30 mentioned this pull request Dec 14, 2025
Open
4 tasks
ahrtr
ahrtr reviewed Dec 14, 2025
View reviewed changes
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from 6d01458 to 9e6d59c Compare December 14, 2025 18:22
@ahrtr
Copy link
Member

ahrtr commented Dec 14, 2025

pls squash commits

@ArkaSaha30
Copy link
Contributor Author

ArkaSaha30 commented Dec 14, 2025

/test pull-etcd-operator-test-e2e

@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from 332aa20 to 4878a77 Compare December 14, 2025 19:31
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from 4878a77 to f22298c Compare December 15, 2025 05:11
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch 2 times, most recently from 7ed8770 to f5f484b Compare December 16, 2025 21:00
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from f5f484b to 69f84fe Compare December 16, 2025 21:01
@ahrtr
Copy link
Member

ahrtr commented Jan 6, 2026

/retest

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jan 6, 2026

@ArkaSaha30: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-operator-test-e2e 69f84fe link true /test pull-etcd-operator-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivanvc ivanvc self-requested a review January 6, 2026 19:15
@ahrtr
Copy link
Member

ahrtr commented Jan 6, 2026

It seems that the test case TestClusterAutoCertCreation/cluster-auto-cert-creation/Wait_for_StatefulSet_readiness is pretty flaky.

ivanvc
ivanvc approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I suggest fixing the flaky test in another pull request. Thanks, Arka.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit f018f64 into etcd-io:main Jan 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanvc ivanvc ivanvc approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees

No one assigned

Labels

approved size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArkaSaha30 @ahrtr @k8s-ci-robot @ivanvc