Feat: Enhance reconcile process to fix inconsistency between etcd cluster and statefullset

[soma00333]

Issue

#26
#27

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soma00333
Once this PR has been reviewed and has the lgtm label, please assign jberkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @soma00333. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ahrtr]

Thanks @soma00333 for the PR.

The change in internal/controller/etcdcluster_controller.go makes sense, could you please deliver a separate PR to include change for that file only?

Adding an e2e test is good, but since we are getting rid of ginkgo. So I suggest to add the e2e test after we remove ginkgo.

Also please integrate the gofail in a separate PR. Let's discuss this effort in #27

[soma00333]

Hi, @ahrtr
I appreciate your review.
I totally agreed
I'll create a new PR to change only internal/controller/etcdcluster_controller.go (To enhance the logic. No gofail this time.)

[soma00333]

[YFI]
I created the PR here #53

[soma00333]

I close this PR