ensure wal lock invariant in create

add the lock for the sake for keeping the invariant during the creation. Signed-off-by: Thomas Jungblut <[email protected]>
etcd-io · Dec 5, 2022 · 6927ebd · 6927ebd
1 parent 5ff9052
commit 6927ebd
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/server/storage/wal/wal.go b/server/storage/wal/wal.go
@@ -158,6 +158,11 @@ func Create(lg *zap.Logger, dirpath string, metadata []byte) (*WAL, error) {
 		dir:      dirpath,
 		metadata: metadata,
 	}
+
+	// this is actually not necessary, as w is not leaving the scope of this function yet.
+	w.mu.Lock()
+	defer w.mu.Unlock()
+
 	w.encoder, err = newFileEncoder(f.File, 0)
 	if err != nil {
 		return nil, err