Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: pin dependencies of rw-heatmaps #15942

Merged
merged 1 commit into from
May 23, 2023
Merged

benchmarks: pin dependencies of rw-heatmaps #15942

merged 1 commit into from
May 23, 2023

Conversation

cenkalti
Copy link
Member

jmhbnz
jmhbnz approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahrtr
ahrtr approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tried to replace the python modules with golang package in #15060, but it has concern from other maintainers. Anyway, It would be better we can completely remove the dependency on python and its modules eventually.

@ahrtr ahrtr merged commit 67c272e into etcd-io:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cenkalti @serathius @ahrtr @jmhbnz