-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downgrade cancellation e2e tests #19252
base: main
Are you sure you want to change the base?
Add downgrade cancellation e2e tests #19252
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 35 files with indirect coverage changes @@ Coverage Diff @@
## main #19252 +/- ##
=======================================
Coverage 68.84% 68.85%
=======================================
Files 420 420
Lines 35689 35693 +4
=======================================
+ Hits 24570 24575 +5
- Misses 9693 9700 +7
+ Partials 1426 1418 -8 Continue to review full report in Codecov by Sentry.
|
7afa927
to
9da71dc
Compare
9da71dc
to
6004df8
Compare
/retest |
6004df8
to
b88f908
Compare
Rebased to main as #19244 is merged |
/retest |
@siyuanfoundation PTAL, thx |
172edc8
to
302fb4c
Compare
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
302fb4c
to
5e865e2
Compare
…or cases like cancelRightAfterEnable Signed-off-by: Chun-Hung Tseng <[email protected]>
5e865e2
to
01690d8
Compare
9ff1e45
to
73a9995
Compare
Signed-off-by: Chun-Hung Tseng <[email protected]>
25dd631
to
a998bec
Compare
@@ -135,7 +162,7 @@ func testDowngradeUpgrade(t *testing.T, clusterSize int, triggerSnapshot bool, t | |||
t.Logf("Cancelling downgrade before enabling") | |||
e2e.DowngradeCancel(t, epc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I was running e2e tests locally, the DowngradeCancel
call times out (Error: etcdserver: request timed out
) quite often, esp. with more nodes downgraded in the cluster.
Reference on CI: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/19252/pull-etcd-e2e-amd64/1884558107229556736
/retest |
edf468c
to
e00a15f
Compare
Signed-off-by: Chun-Hung Tseng <[email protected]>
e00a15f
to
bffb8f9
Compare
I will look into |
kubernetes/test-infra#34236 should resolve the failure. It will be merged a couple of minutes later. |
@henrybear327: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Part 2 of the e2e test - downgrade cancellation is called after the cluster has been partially downgraded (refer to part 1: #19244)
Reference: #17976
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.