Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downgrade cancellation e2e tests #19252

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Jan 21, 2025

Part 2 of the e2e test - downgrade cancellation is called after the cluster has been partially downgraded (refer to part 1: #19244)

Reference: #17976

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (35d20d1) to head (bffb8f9).
Report is 14 commits behind head on main.

Additional details and impacted files

see 35 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19252   +/-   ##
=======================================
  Coverage   68.84%   68.85%           
=======================================
  Files         420      420           
  Lines       35689    35693    +4     
=======================================
+ Hits        24570    24575    +5     
- Misses       9693     9700    +7     
+ Partials     1426     1418    -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d20d1...bffb8f9. Read the comment docs.

@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch 3 times, most recently from 7afa927 to 9da71dc Compare January 28, 2025 12:34
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 9da71dc to 6004df8 Compare January 28, 2025 13:00
@henrybear327 henrybear327 marked this pull request as ready for review January 28, 2025 13:00
@henrybear327
Copy link
Contributor Author

/retest

@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 6004df8 to b88f908 Compare January 28, 2025 13:51
@henrybear327
Copy link
Contributor Author

Rebased to main as #19244 is merged

@henrybear327
Copy link
Contributor Author

/retest

@ahrtr
Copy link
Member

ahrtr commented Jan 28, 2025

@siyuanfoundation PTAL, thx

@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch 2 times, most recently from 172edc8 to 302fb4c Compare January 29, 2025 09:42
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 302fb4c to 5e865e2 Compare January 29, 2025 09:44
…or cases like cancelRightAfterEnable

Signed-off-by: Chun-Hung Tseng <[email protected]>
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 5e865e2 to 01690d8 Compare January 29, 2025 10:12
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 9ff1e45 to 73a9995 Compare January 29, 2025 10:52
Signed-off-by: Chun-Hung Tseng <[email protected]>
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from 25dd631 to a998bec Compare January 29, 2025 11:03
@@ -135,7 +162,7 @@ func testDowngradeUpgrade(t *testing.T, clusterSize int, triggerSnapshot bool, t
t.Logf("Cancelling downgrade before enabling")
e2e.DowngradeCancel(t, epc)
Copy link
Contributor Author

@henrybear327 henrybear327 Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was running e2e tests locally, the DowngradeCancel call times out (Error: etcdserver: request timed out) quite often, esp. with more nodes downgraded in the cluster.

Reference on CI: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/19252/pull-etcd-e2e-amd64/1884558107229556736

@henrybear327
Copy link
Contributor Author

/retest

@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from edf468c to e00a15f Compare January 29, 2025 19:14
Signed-off-by: Chun-Hung Tseng <[email protected]>
@henrybear327 henrybear327 force-pushed the e2e/downgrade_cancellation_partial branch from e00a15f to bffb8f9 Compare January 29, 2025 19:26
@henrybear327
Copy link
Contributor Author

I will look into pull-etcd-release-tests when all other tests have passed. This is probably not related to this PR.

@ahrtr
Copy link
Member

ahrtr commented Jan 29, 2025

I will look into pull-etcd-release-tests when all other tests have passed. This is probably not related to this PR.

kubernetes/test-infra#34236 should resolve the failure. It will be merged a couple of minutes later.

@k8s-ci-robot
Copy link

@henrybear327: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-release-tests bffb8f9 link false /test pull-etcd-release-tests
pull-etcd-e2e-arm64 bffb8f9 link true /test pull-etcd-e2e-arm64
pull-etcd-e2e-amd64 bffb8f9 link true /test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants