Align NewConfig with AddFlags defaults

[serathius]

cc @ahrtr @fuweid @AwesomePatrol @siyuanfoundation

[ahrtr]

We need to update the default value in AddFlags: change the 1 with cfg.SelfSignedCertValidity. This comment applies other fields as well.

etcd/server/embed/config.go

Line 734 in c9045d6

fs.UintVar(&cfg.SelfSignedCertValidity, "self-signed-cert-validity", 1, "The validity period of the client and peer certificates, unit is year")

[serathius]

Done

[ahrtr]

I was saying to change

fs.UintVar(&cfg.SelfSignedCertValidity, "self-signed-cert-validity", 1, "The validity period of the client and peer certificates, unit is year") 

to

fs.UintVar(&cfg.SelfSignedCertValidity, "self-signed-cert-validity", cfg.SelfSignedCertValidity, "The validity period of the client and peer certificates, unit is year") 

Also need to do similar changes for other fields you changed in this PR.

[serathius]

Oh, sorry I misread your comment. I agree with the direction, however I worried about changing defaults by mistake that is easy to miss. So I proposed to make a minimal step that is easily verifiable by test.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (dd60559) to head (93e9072).
Report is 2 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/embed/config.go	79.63% <100.00%> (-0.03%)	⬇️

... and 23 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19254   +/-   ##
=======================================
  Coverage   68.84%   68.85%           
=======================================
  Files         420      420           
  Lines       35693    35702    +9     
=======================================
+ Hits        24573    24582    +9     
+ Misses       9698     9692    -6     
- Partials     1422     1428    +6     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd60559...93e9072. Read the comment docs.

[ahrtr]

LGTM with a minor comment, thx

[ahrtr]

Suggested change

	ExperimentalTxnModeWriteWithSharedBuffer: ExperimentalTxnModeWriteWithSharedBuffer,
	ExperimentalDistributedTracingAddress: ExperimentalDistributedTracingAddress,
	ExperimentalDistributedTracingServiceName: ExperimentalDistributedTracingServiceName,
	ExperimentalTxnModeWriteWithSharedBuffer: DefaultExperimentalTxnModeWriteWithSharedBuffer,
	ExperimentalDistributedTracingAddress: DefaultExperimentalDistributedTracingAddress,
	ExperimentalDistributedTracingServiceName: DefaultExperimentalDistributedTracingServiceName,

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment