Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): set severity of 'ectdMembersDown' from 'critical' to 'wa… #19300

Merged
merged 1 commit into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/mixin/alerts/alerts.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
)
> 0
||| % { etcd_instance_labels: $._config.etcd_instance_labels, etcd_selector: $._config.etcd_selector, network_failure_range: $._config.scrape_interval_seconds * 4 },
'for': '10m',
'for': '20m',
labels: {
severity: 'critical',
severity: 'warning',
},
annotations: {
description: 'etcd cluster "{{ $labels.%s }}": members are down ({{ $value }}).' % $._config.clusterLabel,
Expand Down
26 changes: 13 additions & 13 deletions contrib/mixin/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,24 @@ tests:
- interval: 1m
input_series:
- series: up{job="etcd",instance="10.10.10.0"}
values: 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0
values: 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0
- series: up{job="etcd",instance="10.10.10.1"}
values: 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0
values: 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
- series: up{job="etcd",instance="10.10.10.2"}
values: 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0 0
values: 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
alert_rule_test:
- eval_time: 3m
alertname: etcdInsufficientMembers
- eval_time: 5m
alertname: etcdInsufficientMembers
- eval_time: 12m
- eval_time: 22m
alertname: etcdMembersDown
- eval_time: 14m
- eval_time: 24m
alertname: etcdMembersDown
exp_alerts:
- exp_labels:
job: etcd
severity: critical
severity: warning
exp_annotations:
description: 'etcd cluster "etcd": members are down (3).'
summary: etcd cluster members are down.
Expand Down Expand Up @@ -55,30 +55,30 @@ tests:
- series: up{job="etcd",instance="10.10.10.2"}
values: 1 1 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
alert_rule_test:
- eval_time: 14m
- eval_time: 24m
alertname: etcdMembersDown
exp_alerts:
- exp_labels:
job: etcd
severity: critical
severity: warning
exp_annotations:
description: 'etcd cluster "etcd": members are down (3).'
summary: etcd cluster members are down.
- interval: 1m
input_series:
- series: up{job="etcd",instance="10.10.10.0"}
values: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0
values: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0
- series: up{job="etcd",instance="10.10.10.1"}
values: 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0
values: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0
- series: etcd_network_peer_sent_failures_total{To="member-1",job="etcd",endpoint="test"}
values: 0 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
values: 0 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
alert_rule_test:
- eval_time: 13m
- eval_time: 23m
alertname: etcdMembersDown
exp_alerts:
- exp_labels:
job: etcd
severity: critical
severity: warning
exp_annotations:
description: 'etcd cluster "etcd": members are down (1).'
summary: etcd cluster members are down.
Expand Down