-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prometheus metric #19452
base: main
Are you sure you want to change the base?
add prometheus metric #19452
Conversation
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cad579d
to
2bd2be7
Compare
2bd2be7
to
8b80564
Compare
7abf517
to
70b4119
Compare
/cc @ahrtr |
sorry @ahrtr, assign to you by mistake. I was trying to add you to reviewer list. |
/cc @ahrtr |
70b4119
to
9995656
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangli113 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9995656
to
b5bd6ae
Compare
bba7790
to
1ca78b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 26 files with indirect coverage changes @@ Coverage Diff @@
## main #19452 +/- ##
==========================================
+ Coverage 68.90% 69.02% +0.12%
==========================================
Files 420 420
Lines 35753 35771 +18
==========================================
+ Hits 24636 24692 +56
+ Misses 9693 9660 -33
+ Partials 1424 1419 -5 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Gang Li <[email protected]> Signed-off-by: Gang Li <[email protected]>
1ca78b3
to
ebf03a7
Compare
Fix #19324
Add a prometheus metric
etcd_server_feature_enabled
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.