Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus metric #19452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add prometheus metric #19452

wants to merge 1 commit into from

Conversation

gangli113
Copy link
Contributor

@gangli113 gangli113 commented Feb 20, 2025

Fix #19324

Add a prometheus metric etcd_server_feature_enabled

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangli113 gangli113 force-pushed the featuregate branch 2 times, most recently from 7abf517 to 70b4119 Compare February 21, 2025 19:08
@gangli113
Copy link
Contributor Author

gangli113 commented Feb 21, 2025

/cc @ahrtr

@gangli113
Copy link
Contributor Author

sorry @ahrtr, assign to you by mistake. I was trying to add you to reviewer list.

@gangli113
Copy link
Contributor Author

/cc @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangli113
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.02%. Comparing base (deb9178) to head (1ca78b3).
Report is 19 commits behind head on main.

Current head 1ca78b3 differs from pull request most recent head ebf03a7

Please upload reports for the commit ebf03a7 to get more accurate results.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/featuregate/feature_gate.go 89.54% <100.00%> (+1.18%) ⬆️
server/etcdserver/metrics.go 80.85% <100.00%> (+0.41%) ⬆️
server/etcdserver/server.go 82.67% <100.00%> (+0.90%) ⬆️

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19452      +/-   ##
==========================================
+ Coverage   68.90%   69.02%   +0.12%     
==========================================
  Files         420      420              
  Lines       35753    35771      +18     
==========================================
+ Hits        24636    24692      +56     
+ Misses       9693     9660      -33     
+ Partials     1424     1419       -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb9178...ebf03a7. Read the comment docs.

Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add Prometheus gauge metrics for server feature gate
5 participants