Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use empty struct instead of bool for map values #19457

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: use empty struct instead of bool for map values #19457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20c4929
perf: use empty struct instead of bool for map values
Feb 21, 2025
5fbba89
chore: adjust import order
Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/storage/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@
// - ConfChangeRemoveNode, in which case the contained ID will Be removed from the set.
// - ConfChangeAddLearnerNode, in which the contained ID will Be added into the set.
func GetEffectiveNodeIDsFromWALEntries(lg *zap.Logger, snap *raftpb.Snapshot, ents []raftpb.Entry) []uint64 {
ids := make(map[uint64]bool)
ids := make(map[uint64]struct{})
if snap != nil {
for _, id := range snap.Metadata.ConfState.Voters {
ids[id] = true
ids[id] = struct{}{}
}
}
for _, e := range ents {
Expand All @@ -140,9 +140,9 @@
pbutil.MustUnmarshal(&cc, e.Data)
switch cc.Type {
case raftpb.ConfChangeAddLearnerNode:
ids[cc.NodeID] = true
ids[cc.NodeID] = struct{}{}

Check warning on line 143 in server/storage/util.go

View check run for this annotation

Codecov / codecov/patch

server/storage/util.go#L143 

Added line #L143 was not covered by tests
case raftpb.ConfChangeAddNode:
ids[cc.NodeID] = true
ids[cc.NodeID] = struct{}{}
case raftpb.ConfChangeRemoveNode:
delete(ids, cc.NodeID)
case raftpb.ConfChangeUpdateNode:
Expand Down