Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused and deprecated func GetEffectiveNodeIdsFromWalEntries #19458

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: remove unused and deprecated func GetEffectiveNodeIdsFromWalEntries #19458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68c2fae
chore: remove unused and deprecated func `GetEffectiveNodeIdsFromWalE…
Feb 21, 2025
1c7f006
chore: adjust import order
Feb 21, 2025
8ce740c
chore: adjust import order
Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions server/storage/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,6 @@ func CreateConfigChangeEnts(lg *zap.Logger, ids []uint64, self uint64, term, ind
return ents
}

// GetEffectiveNodeIdsFromWalEntries returns an ordered set of IDs included in the given snapshot and
// the entries.
//
// Deprecated: use GetEffectiveNodeIDsFromWALEntries instead.
//
//revive:disable-next-line:var-naming
func GetEffectiveNodeIdsFromWalEntries(lg *zap.Logger, snap *raftpb.Snapshot, ents []raftpb.Entry) []uint64 {
return GetEffectiveNodeIDsFromWALEntries(lg, snap, ents)
}

// GetEffectiveNodeIDsFromWALEntries returns an ordered set of IDs included in the given snapshot and
// the entries. The given snapshot/entries can contain three kinds of
// ID-related entry:
Expand Down