[3.4] dependency: Bump golang.org/x/crypto from v0.32.0 to v0.35.0 #19477
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address CVE-2025-22869. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
commented
Feb 24, 2025
| @@ -1,6 +1,6 @@ | |||
| module go.etcd.io/etcd | |||
|
|
|||
| go 1.23 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
Refer to the note in the description of this PR.
fuweid
approved these changes
Feb 24, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fuweid, ivanvc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address CVE-2025-22869.
There's a change to
go.mod'sgodirective setting the patch to 1.23.0. I know we had a conversation recently (#19429 (comment)). And we settled down on removing the patch version. However, becausegolang.org/xdependencies now specify up to the patch (refer to: https://cs.opensource.google/go/x/crypto/+/refs/tags/v0.34.0:go.mod;bpv=1;bpt=0;drc=89ff08d67c4d79f9ac619aaf1f7388888798651f;dlc=9290511cd23ab9813a307b7f2615325e3ca98902), it rolls over to ourgo.mod. Therefore, go commands fail, complaining that we need to run ago mod tidy.For example, see the failed CI run: https://github.com/ivanvc/etcd/actions/runs/13509030553/job/37745180781.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.