-
Notifications
You must be signed in to change notification settings - Fork 10.2k
etcdctl: fix lease comparison in txn #20774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Petr Bodunov <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PetrBodunov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @PetrBodunov. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| cmp = clientv3.Compare(clientv3.Value(key), op, val) | ||
| case "lease": | ||
| cmp = clientv3.Compare(clientv3.Cmp{Target: pb.Compare_LEASE}, op, val) | ||
| if v, err = strconv.ParseInt(val, 16, 64); err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test?
|
/ok-to-test |
|
@PetrBodunov: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #20774 +/- ##
==========================================
+ Coverage 69.16% 69.21% +0.04%
==========================================
Files 422 422
Lines 34819 34822 +3
==========================================
+ Hits 24082 24101 +19
+ Misses 9340 9331 -9
+ Partials 1397 1390 -7 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Added parse into hex for lease id in lease comparison in txn.
Fix #20773