Mi300: cray fix + egl #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
! ! ! WARNING ! ! ! this PR is set to be merged on
mi300-acceptancebranchChangelog:
cray-*packages applied on master needed for newer spack versionseglas externalcray-*:buildable:trueFix for newer spack versions, where cray packages have been marked as not-buildable. See #20
EGL
Why is useful? First use-case we have is for
hip, that requires aglprovider. Using an externaleglallows to skip build ofglxthat comes with a quite big tree of dependencies to build (and it seems to bring in also a problem with the concretizer that might end up choosing a not "ideal" configuration).About version. I'm not sure
1.5.0is correct, but I'm not even sure it would make any difference. I tried to figure it out, but both withzypperand with a manually builteglinfo, I was not able to pinpoint a single version.In
eglinfoI was able to see that both 1.4.0 and 1.5.0 are supported, but it depends on the platform used (probably 1.4.0 might be the correct choice). The name of the library seems to point to 1.1.0, but it sounds a bit off to me.