-
Notifications
You must be signed in to change notification settings - Fork 33
Add dummysph check #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dummysph check #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new test framework for validating the Ascent library integration with DummySPH code. The implementation includes comprehensive test coverage for various parameter combinations and build configurations.
- Adds ReFrame test class for building and running DummySPH with Ascent visualization library
- Implements parameterized testing across different data formats (Tipsy/H5Part), precision levels, and visualization operations
- Includes shell script for parsing and extracting test results from JSON output
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| checks/apps/dummysph/dummysph.py | Main ReFrame test implementation with build configuration, parameter handling, and validation logic |
| checks/apps/dummysph/scripts/dummysph.sh | Shell script for parsing JSON test results and extracting test case information |
Comments suppressed due to low confidence (1)
checks/apps/dummysph/scripts/dummysph.sh:3
- [nitpick] The variable name 'in' is not descriptive. Consider renaming it to 'input_file' or 'json_file' to clarify its purpose.
in=$1
|
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/24.11:v2 |
|
4 tests fail (expectedly): |
|
cscs-ci run alps-daint-uenv;MY_UENV=insitu_ascent/0.9.5:v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.