Skip to content

Conversation

@jgphpc
Copy link
Collaborator

@jgphpc jgphpc commented Jul 23, 2025

  • Testing Ascent library using DummySPH code.
  • Share the command line used to run the test
  • deploy the ascent uenv -> ascent alps-uenv#194
UENV=insitu_ascent/0.9.5:v1 reframe -c checks/apps/dummysph/dummysph.py -n OFF.*OFF.*OFF.*OFF.*rend -r

UENV=/iopsstor/scratch/cscs/piccinal/bristen/ascent/ascent-0.9.5-gcc13-cuda1281-debug.sqfs \
reframe --system bristen:normal -c checks/apps/dummysph/dummysph.py -r

UENV=/capstor/scratch/cscs/piccinal/ascent/ascent-0.9.5-gcc13-cuda1281-debug.sqfs \
reframe --system daint:normal -c checks/apps/dummysph/dummysph.py -r

cscs-ci run alps-daint-uenv;MY_UENV=insitu_ascent/0.9.5:v1

@jgphpc jgphpc requested a review from Copilot July 23, 2025 18:30
@jgphpc jgphpc self-assigned this Jul 23, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test framework for validating the Ascent library integration with DummySPH code. The implementation includes comprehensive test coverage for various parameter combinations and build configurations.

  • Adds ReFrame test class for building and running DummySPH with Ascent visualization library
  • Implements parameterized testing across different data formats (Tipsy/H5Part), precision levels, and visualization operations
  • Includes shell script for parsing and extracting test results from JSON output

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
checks/apps/dummysph/dummysph.py Main ReFrame test implementation with build configuration, parameter handling, and validation logic
checks/apps/dummysph/scripts/dummysph.sh Shell script for parsing JSON test results and extracting test case information
Comments suppressed due to low confidence (1)

checks/apps/dummysph/scripts/dummysph.sh:3

  • [nitpick] The variable name 'in' is not descriptive. Consider renaming it to 'input_file' or 'json_file' to clarify its purpose.
in=$1

@jgphpc
Copy link
Collaborator Author

jgphpc commented Jul 23, 2025

cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/24.11:v2

@jgphpc
Copy link
Collaborator Author

jgphpc commented Jul 23, 2025

4 tests fail (expectedly):

FAILURE INFO for DummySPH_Uenv_Ascent_Single %aos=OFF %fp64=OFF %tipsy=OFF %h5part=OFF %test=compositing (run: 1/1)
  * Reason: sanity error: found "Field type unsupported for conversion to blueprint"

FAILURE INFO for DummySPH_Uenv_Ascent_Single %aos=OFF %fp64=OFF %tipsy=OFF %h5part=OFF %test=histsampling (run: 1/1)
  * Reason: sanity error: found "Execution failed with vtkm: Cast failed: vtkm::cont::ArrayHandle"

FAILURE INFO for DummySPH_Uenv_Ascent_Single %aos=OFF %fp64=OFF %tipsy=OFF %h5part=ON %test=histsampling (run: 1/1)
  * Reason: sanity error: found "Execution failed with vtkm: Cast failed: vtkm::cont::ArrayHandle"

FAILURE INFO for DummySPH_Uenv_Ascent_Single %aos=OFF %fp64=ON %tipsy=OFF %h5part=OFF %test=compositing (run: 1/1)
  * Reason: sanity error: found "Field type unsupported for conversion to blueprint"

Total number of test cases: 20
Total number of failures: 4

@jgphpc jgphpc requested a review from ekouts July 25, 2025 06:44
@jgphpc
Copy link
Collaborator Author

jgphpc commented Jul 25, 2025

cscs-ci run alps-daint-uenv;MY_UENV=insitu_ascent/0.9.5:v1

@jgphpc
Copy link
Collaborator Author

jgphpc commented Aug 4, 2025

@jgphpc jgphpc marked this pull request as draft August 26, 2025 07:22
@jgphpc jgphpc marked this pull request as ready for review October 2, 2025 15:36
@jgphpc jgphpc requested a review from Copilot October 2, 2025 15:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jgphpc jgphpc marked this pull request as draft October 2, 2025 15:45
@jgphpc jgphpc requested a review from Copilot October 20, 2025 18:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jgphpc jgphpc marked this pull request as ready for review October 20, 2025 19:07
@ekouts ekouts merged commit dda52c1 into eth-cscs:main Oct 21, 2025
1 check passed
@jgphpc jgphpc deleted the test/ascent branch October 24, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants