Repository navigation
Conversation
The viewer list depended on an inverted `command -v eza` check, and the two lists were different. With eza installed, batpipe did not open .tgz archives and used exa or ls for directories. Without eza, it did not open .tbz archives and did not use exa. This change keeps the intent of the two earlier changes: - eth-p#105 wanted exa as a fallback when eza is not installed. Each viewer already checks its own command, so the order "eza" "exa" gives this fallback. ls stays the last directory viewer. - eth-p#103 added the tar_gz and tar_bz2 viewers to one list. The merge with eth-p#105 (ba984f4) put them in different lists. Fixes eth-p#153 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test that batpipe opens files inside .tgz and .tbz archives with and without eza on the PATH, and that it uses eza for directories when eza is installed. The tests put an eza stub on the PATH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
The CI failures are not caused by this change:
The Build and Test jobs failed in the same way on 🤖 Generated with Claude Code |
This was referenced Sep 30, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153.
Change
batpipe selected one of two viewer lists with an inverted
command -v ezacheck. This change replaces the two lists with one list:The change keeps the intent of the two earlier changes:
exaas a fallback whenezais not installed. Eachviewer_*_supportsfunction exceptviewer_ls_supportsalready checks its command. Thus the order"eza" "exa"gives this fallback, andlsstays the last directory viewer.tar_gzandtar_bz2viewers to one list. The merge with change all references to exa to eza #105 (ba984f4) put them in different lists.Tests
The second commit adds three tests to
test/suite/batpipe.shand two small archives totest/data:viewer_tar_gzandviewer_tar_bz2open a file inside a.tgzand a.tbzarchive. Each test runs once with the currentPATHand once with anezastub first on thePATH.viewer_ezamakes sure that batpipe usesezafor directories whenezais installed.Results of
./test.sh --suite batpipe:ezainstalledviewer_tar_gzandviewer_ezafail)ezainPATHviewer_tar_bz2,viewer_tar_gzandviewer_ezafail)batpipe_term_widthfails in all four runs. It also fails onmasterwithout this change, so it is not related to this change.🤖 Generated with Claude Code