Skip to content

Expose full state on deactivation #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose full state on deactivation #34

wants to merge 1 commit into from

Conversation

ragalie
Copy link

@ragalie ragalie commented May 18, 2020

Everything in the state should be accurate, regardless of whether it's active. It's useful to have the shape of the object sent to the onPositionChanged callback be the same regardless of activation.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5d769b5 on ragalie:expose-state-on-deactivation into 0f594bb on ethanselzer:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ragalie @coveralls