Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IDRX #1101

Merged
merged 1 commit into from
Apr 4, 2025
Merged

add IDRX #1101

merged 1 commit into from
Apr 4, 2025

Conversation

IfanWijaya
Copy link
Contributor

Description

Add IDRX Token on Base and Lisk.

Tests

Additional context

Metadata

@IfanWijaya IfanWijaya requested review from wbnns and a team as code owners March 13, 2025 04:15
@IfanWijaya
Copy link
Contributor Author

@shuse2

@shuse2 shuse2 self-requested a review March 13, 2025 11:32
@shuse2 shuse2 added the lisk PR require review from lisk team label Mar 13, 2025
@fainashalts fainashalts added the base PR require review from base team label Mar 20, 2025
@wbnns
Copy link
Member

wbnns commented Mar 25, 2025

Looks good from the Base side; we'll need a +1 from the Lisk side to bring this in

@IfanWijaya
Copy link
Contributor Author

@shuse2 all good from lisk side?

shuse2
shuse2 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took a bit long, but all good from our side as well 💪

@fainashalts
Copy link
Collaborator

merging this in as it looks like we have 👍 from Base and Lisk!

@fainashalts fainashalts merged commit 0586352 into ethereum-optimism:master Apr 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@fainashalts fainashalts fainashalts approved these changes

@Stellaluciano Stellaluciano Stellaluciano approved these changes

@wbnns wbnns Awaiting requested review from wbnns wbnns is a code owner

Assignees
No one assigned
Labels
base PR require review from base team lisk PR require review from lisk team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IfanWijaya @wbnns @fainashalts @shuse2 @Stellaluciano