-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(op-signer): generate TLS certs using Docker #255
feat(op-signer): generate TLS certs using Docker #255
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 53.63% 53.43% -0.20%
==========================================
Files 67 67
Lines 7881 7753 -128
==========================================
- Hits 4227 4143 -84
+ Misses 3373 3332 -41
+ Partials 281 278 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
I ran into this error when testing locally: ❯ curl --cert tls/tls.crt --key tls/tls.key -X POST -H "Content-Type: application/json" -d @test-rpc.json https://localhost:8080
client certificate verified but did not contain DNS SAN extension and have made some changes to fix it, the necessary step was adding Great contribution btw, ty! |
Use Docker for OpenSSL Operations
This PR updates the
gen-local-tls.sh
script to use Docker for all OpenSSL operations, eliminating the need for local OpenSSL installation and version compatibility checks.Changes
alpine/openssl:3.3.3
This approach ensures consistent behavior across different development environments and simplifies the setup process for new contributors.
Testing
I have tested this change by running