663: Update SWAP/DUP to use EIP-3540 #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, why was this automerged? It is a status change from Stagnant to Draft. |
|
Oof, most likely because you're an editor and so can override the bot. I'll patch it asap |
|
Nevermind I found a real issue, patching... |
alita-moore
added a commit
that referenced
this pull request
Feb 3, 2022
This reverts commit ce7a796.
alita-moore
added a commit
that referenced
this pull request
Feb 3, 2022
|
the problem was that in draft state the bot is skipped and when you go from draft -> review the bot is not re-run so it remains in the skipped state. The kodiak auto-merger considers skipped as success. There are a few ways for us to address this but the easiest is to disable / remove kodiak until it no longer does this. see chdsbd/kodiak#780 for an investigation on this topic |
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.