Add ERC: HD wallet In Treasury Management #978

elizabethxiaoyu · 2025-03-17T12:32:46Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eip-review-bot · 2025-03-17T12:33:08Z

✅ All reviewers have approved.

…proposal

elizabethxiaoyu · 2025-03-17T12:42:55Z

Discuss To：https://ethereum-magicians.org/t/new-erc-deterministic-account-hierarchy-in-treasury-management/23073
Look forward to your comments~

bomanaps · 2025-03-17T18:20:44Z

ERCS/erc-treasury_hd_wallet.md

+```python
+entity_hash = sha256(f"ENTITY:{entity}".encode()).digest()  
+entity_index = (int.from_bytes(entity_hash[:4], "big") % 2**31) + 2**31  # 2^31 ≤ index < 2^32
+```
+
+2. **Department Index Calculation**
+
+   - **MUST** compute `department_id` as:
+
+```python
+dept_hash = sha256(f"DEPT:{entity_hash}:{department}".encode()).digest()  
+dept_index = (int.from_bytes(dept_hash[:4], "big") % 2^31) + 2^31
+```
+
+3. **Output Constraints**
+
+   - Generated indices **MUST** be integers in `[2^31, 2^32-1]` to enforce hardened derivation.


The current calculation method in this proposal is (89-90):

entity_hash = sha256(f"ENTITY:{entity}".encode()).digest() entity_index = (int.from_bytes(entity_hash[:4], "big") % 2**31) + 2**31

Some problems to this:

Range Limitation: looking at line 104 it states indices must be in the range [2^31, 2^32-1] for hardened derivation, the modulo operation unnecessarily restricts the possible values, reducing entropy.
Entropy Loss: Taking the modulo of the hash value with 2^31 means we're only using approximately 30 bits of entropy from the original 32 bits (4 bytes), potentially increasing collision risk.
Implementation Inconsistency: The code example uses % 2^31 which in Python would be interpreted as a bitwise XOR operation rather than exponentiation (should be % 2**31)?

Thank you for your comments, I have optimized logic in the last pr: remain 32 bits to decrease collision risk and modify typo

bomanaps · 2025-03-17T18:30:17Z

ERCS/erc-treasury_hd_wallet.md

+
+6. **Account Index (**`account_index`**)**
+
+   - **MUST** use non-hardened derivation to allow unified account management.


What happens if the parent public key is compromised?

The design of unreinforced derivation makes it possible for the parent private key to be derived once both of the following conditions are met:

The parent public key (xpub) and chain code are known (xpub is public).

A child private key is leaked.
but convenience and risk need to balance~ and risk notify has been added in chapter "Security Considerations"

bomanaps · 2025-03-17T18:34:53Z

ERCS/erc-treasury_hd_wallet.md

+This proposal aims to provide a standardized method for on-chain treasury management of institutional assets, ensuring
+secure private key generation, hierarchical management, and departmental permission isolation while supporting asset
+security and transaction efficiency in multi-chain environments. By defining a unified derivation path and security
+mechanisms, this proposal offers an efficient and secure solution for treasury management.


Suggested change

This proposal aims to provide a standardized method for on-chain treasury management of institutional assets, ensuring

secure private key generation, hierarchical management, and departmental permission isolation while supporting asset

security and transaction efficiency in multi-chain environments. By defining a unified derivation path and security

mechanisms, this proposal offers an efficient and secure solution for treasury management.

This proposal aims to provide a standardized method for on-chain treasury management of institutional assets, ensuring secure private key generation, hierarchical management, and departmental permission isolation while supporting asset security and transaction efficiency in multi-chain environments. By defining a unified derivation path and security mechanisms, this proposal offers an efficient and secure solution for treasury management.

bomanaps · 2025-03-17T18:38:24Z

ERCS/erc-treasury_hd_wallet.md

+With the rapid development of blockchain and DeFi, secure management of on-chain assets has become critical. Traditional
+private key management struggles to meet the security demands of large organizations in complex scenarios, where
+hierarchical key management, permission controls, and multi-signature mechanisms are essential. This proposal provides a
+standardized solution for institutional treasury management, ensuring asset security and transaction efficiency.


Suggested change

With the rapid development of blockchain and DeFi, secure management of on-chain assets has become critical. Traditional

private key management struggles to meet the security demands of large organizations in complex scenarios, where

hierarchical key management, permission controls, and multi-signature mechanisms are essential. This proposal provides a

standardized solution for institutional treasury management, ensuring asset security and transaction efficiency.

With the rapid development of blockchain and DeFi, secure management of on-chain assets has become critical. Traditional private key management struggles to meet the security demands of large organizations in complex scenarios, where hierarchical key management, permission controls, and multi-signature mechanisms are essential. This proposal provides a standardized solution for institutional treasury management, ensuring asset security and transaction efficiency.

bomanaps · 2025-03-17T18:39:11Z

ERCS/erc-treasury_hd_wallet.md

+For treasury managers, hierarchical deterministic wallet management is more convenient, but it requires additional
+consideration of protective measures for the master key, such as schemes for splitting and storing mnemonic phrases or
+master keys.


Suggested change

For treasury managers, hierarchical deterministic wallet management is more convenient, but it requires additional

consideration of protective measures for the master key, such as schemes for splitting and storing mnemonic phrases or

master keys.

For treasury managers, hierarchical deterministic wallet management is more convenient, but it requires additional consideration of protective measures for the master key, such as schemes for splitting and storing mnemonic phrases or master keys.

…o treasury_hd_wallet_proposal

elizabethxiaoyu · 2025-03-18T08:05:12Z

@eip-review-bot can scan again?

github-actions · 2025-03-19T03:59:01Z

The commit cf60b35 (as a parent of 7f90365) contains errors.
Please inspect the Run Summary for details.

elizabethxiaoyu · 2025-03-19T06:37:09Z

@eip-review-bot @g11tech @SamWilsn @xinbenlv , could you kindly review this pull request? All checks have been successfully completed. Thank you!

SamWilsn · 2025-03-25T01:23:23Z

Friendly reminder to keep technical discussion on the discussion thread and not on the pull requests. Discussions here should only be for formatting and editorial comments. It's too easy to lose context across pull requests otherwise.

elizabethxiaoyu · 2025-04-08T10:12:18Z

Friendly reminder to keep technical discussion on the discussion thread and not on the pull requests. Discussions here should only be for formatting and editorial comments. It's too easy to lose context across pull requests otherwise.

Hi,SamWilsn @SamWilsn , can kindly help to pass merge request? I have already passed all auto checks. Thank you very much~

SamWilsn

This is fine for a draft, though you should address these comments before moving to review.

As a general note, we prefer the form "BIP XX" (no dash or leading zeroes).

SamWilsn · 2025-06-16T17:38:15Z

ERCS/erc-7908.md

+---
+eip: 7908
+title: HD wallet In Treasury Management
+description: HD wallets for treasury systems, isolating entities and departments via cryptographic key paths.


HD wallets for treasury systems,

This section of your description is basically just restating your title, which is an inefficient use of the limited space in the description field. I'd remove it.

Instead, you might consider expanding "HD" or perhaps describing a use case.

SamWilsn · 2025-06-16T17:45:31Z

ERCS/erc-7908.md

+
+   - **SHALL** represent the root HD wallet private key.
+
+2. **BIP-44 Compliance Layer (`44'`)**


Suggested change

2. **BIP-44 Compliance Layer (`44'`)**

2. **[BIP 44](https://github.com/bitcoin/bips/blob/0278bf3d7111bab8f0ef8dd08f16fd7b5ac6cbd6/bip-0044.mediawiki) Compliance Layer (`44'`)**

SamWilsn · 2025-06-16T17:47:05Z

ERCS/erc-7908.md

+
+**Cryptographic Requirements**:
+
+- **SHALL** use BIP-0032 with `secp256k1` for HD derivation.


Suggested change

- **SHALL** use BIP-0032 with `secp256k1` for HD derivation.

- **SHALL** use [BIP 32](https://github.com/bitcoin/bips/blob/a3a397c82384220fc871852c809f73898a4d547c/bip-0032.mediawiki) with `secp256k1` for HD derivation.

SamWilsn · 2025-06-16T17:48:46Z

ERCS/erc-7908.md

+
+## Backwards Compatibility
+
+This standard complies with BIP39、BIP32、BIP44.


Suggested change

This standard complies with BIP39、BIP32、BIP44.

This standard complies with [BIP 39](https://github.com/bitcoin/bips/blob/b9f9a8d6e854fa0b0c8f818753420b0aa6e875aa/bip-0039.mediawiki), [BIP 32](https://github.com/bitcoin/bips/blob/a3a397c82384220fc871852c809f73898a4d547c/bip-0032.mediawiki), [BIP 44](https://github.com/bitcoin/bips/blob/0278bf3d7111bab8f0ef8dd08f16fd7b5ac6cbd6/bip-0044.mediawiki).

eip-review-bot

All Reviewers Have Approved; Performing Automatic Merge...

jiushi.lxy added 2 commits March 7, 2025 16:18

add new erc

4e1ef49

add new erc

c700c5b

elizabethxiaoyu requested a review from eip-review-bot as a code owner March 17, 2025 12:32

github-actions bot added c-new s-draft t-erc labels Mar 17, 2025

eip-review-bot added e-consensus e-review labels Mar 17, 2025

eip-review-bot changed the title ~~New ERCTreasury hd wallet proposal~~ Add ERC: Deterministic Account Hierarchy In Treasury Management Mar 17, 2025

elizabethxiaoyu and others added 2 commits March 17, 2025 20:37

Merge branch 'master' into treasury_hd_wallet_proposal

43c75a9

Merge remote-tracking branch 'origin/master' into treasury_hd_wallet_…

14fc69a

…proposal

github-actions bot added the w-ci label Mar 17, 2025

elizabethxiaoyu mentioned this pull request Mar 17, 2025

Add ERC: Splitting and Merging of NFTs #977

Closed

bomanaps reviewed Mar 17, 2025

View reviewed changes

jiushi.lxy added 2 commits March 18, 2025 15:35

modify proposal according to reviewer's comments

f83a446

Merge remote-tracking branch 'origin/treasury_hd_wallet_proposal' int…

025fbd7

…o treasury_hd_wallet_proposal

jiushi.lxy and others added 4 commits March 18, 2025 16:20

update img trace

20f9537

Merge branch 'master' into treasury_hd_wallet_proposal

e5453f3

update name format using pr number

1f61e1a

optimize format

ad1b394

github-actions bot added w-ci and removed w-ci labels Mar 19, 2025

optimize format according to auto check

9d21034

eip-review-bot changed the title ~~Add ERC: Deterministic Account Hierarchy In Treasury Management~~ Add ERC: HD wallet In Treasury Management Mar 19, 2025

github-actions bot added w-ci and removed w-ci labels Mar 19, 2025

optimize format according to auto check-1

7d6dec2

github-actions bot added the w-ci label Mar 19, 2025

optimize format according to auto check-3

d04c4dc

github-actions bot removed the w-ci label Mar 19, 2025

fix typo

1f5e158

elizabethxiaoyu requested a review from bomanaps March 20, 2025 04:15

SamWilsn and others added 4 commits March 24, 2025 21:28

Assign EIP number

2480158

Merge branch 'master' into treasury_hd_wallet_proposal

5f29189

Merge branch 'master' into treasury_hd_wallet_proposal

1346d20

Merge branch 'master' into treasury_hd_wallet_proposal

d69d0cd

elizabethxiaoyu changed the title ~~Add ERC: HD wallet In Treasury Management~~ Add ERC-7908: HD wallet In Treasury Management Apr 8, 2025

Merge branch 'master' into treasury_hd_wallet_proposal

eec104a

eip-review-bot changed the title ~~Add ERC-7908: HD wallet In Treasury Management~~ Add ERC: HD wallet In Treasury Management Apr 17, 2025

elizabethxiaoyu added 2 commits April 18, 2025 18:44

Merge branch 'master' into treasury_hd_wallet_proposal

3c85cbc

Merge branch 'master' into treasury_hd_wallet_proposal

4df080a

elizabethxiaoyu changed the title ~~Add ERC: HD wallet In Treasury Management~~ ERC-7908: HD wallet In Treasury Management Apr 24, 2025

Merge branch 'master' into treasury_hd_wallet_proposal

5098135

eip-review-bot changed the title ~~ERC-7908: HD wallet In Treasury Management~~ Add ERC: HD wallet In Treasury Management Apr 25, 2025

elizabethxiaoyu added 4 commits May 9, 2025 10:20

Merge branch 'master' into treasury_hd_wallet_proposal

05bcaa2

Merge branch 'master' into treasury_hd_wallet_proposal

b39b90b

Merge branch 'master' into treasury_hd_wallet_proposal

4700158

Merge branch 'master' into treasury_hd_wallet_proposal

31093fd

poojaranjan mentioned this pull request Jun 6, 2025

ERC Blitz | June 10, 2025 ethcatherders/EIPIP#387

Open

53 tasks

SamWilsn approved these changes Jun 16, 2025

View reviewed changes

eip-review-bot enabled auto-merge (squash) June 16, 2025 17:50

eip-review-bot approved these changes Jun 16, 2025

View reviewed changes

eip-review-bot merged commit f7885f6 into ethereum:master Jun 16, 2025
10 of 11 checks passed


		6. Account Index (`account_index`)

		- MUST use non-hardened derivation to allow unified account management.


		- SHALL represent the root HD wallet private key.

		2. BIP-44 Compliance Layer (`44'`)

	2. BIP-44 Compliance Layer (`44'`)
	2. [BIP 44](https://github.com/bitcoin/bips/blob/0278bf3d7111bab8f0ef8dd08f16fd7b5ac6cbd6/bip-0044.mediawiki) Compliance Layer (`44'`)


		Cryptographic Requirements:

		- SHALL use BIP-0032 with `secp256k1` for HD derivation.

	- SHALL use BIP-0032 with `secp256k1` for HD derivation.
	- SHALL use [BIP 32](https://github.com/bitcoin/bips/blob/a3a397c82384220fc871852c809f73898a4d547c/bip-0032.mediawiki) with `secp256k1` for HD derivation.


		## Backwards Compatibility

		This standard complies with BIP39、BIP32、BIP44.

	This standard complies with BIP39、BIP32、BIP44.
	This standard complies with [BIP 39](https://github.com/bitcoin/bips/blob/b9f9a8d6e854fa0b0c8f818753420b0aa6e875aa/bip-0039.mediawiki), [BIP 32](https://github.com/bitcoin/bips/blob/a3a397c82384220fc871852c809f73898a4d547c/bip-0032.mediawiki), [BIP 44](https://github.com/bitcoin/bips/blob/0278bf3d7111bab8f0ef8dd08f16fd7b5ac6cbd6/bip-0044.mediawiki).

Add ERC: HD wallet In Treasury Management #978

Add ERC: HD wallet In Treasury Management #978

Uh oh!

Conversation

elizabethxiaoyu commented Mar 17, 2025

Uh oh!

eip-review-bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elizabethxiaoyu commented Mar 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elizabethxiaoyu Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elizabethxiaoyu commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

elizabethxiaoyu commented Mar 19, 2025

Uh oh!

SamWilsn commented Mar 25, 2025

Uh oh!

elizabethxiaoyu commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SamWilsn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eip-review-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eip-review-bot commented Mar 17, 2025 •

edited

Loading

elizabethxiaoyu Mar 18, 2025 •

edited

Loading

elizabethxiaoyu commented Apr 8, 2025 •

edited

Loading