[WIP] Adding casper deployment instruction to readme.md #152 by GagziW · Pull Request #162 · ethereum/casper

GagziW · 2018-06-01T04:21:30Z

No description provided.

zaq1tomo · 2018-06-06T05:17:48Z

According to your README, params of init() like this.

casper_args = [
  EPOCH_LENGTH,
  WARM_UP_PERIOD,
  WITHDRAWAL_DELAY,
  DYNASTY_LOGOUT_DELAY,
  msg_hasher_address,
  purity_checker_address,
  BASE_INTEREST_FACTOR,
  BASE_PENALTY_FACTOR,
  MIN_DEPOSIT_SIZE
]

But in https://github.com/ethereum/casper/blob/master/casper/contracts/simple_casper.v.py#L130
like this.

def init(
        epoch_length: int128,
        warm_up_period: int128,
        withdrawal_delay: int128,
        dynasty_logout_delay: int128,
        msg_hasher: address,
        purity_checker: address,
        null_sender: address,
        base_interest_factor: decimal,
        base_penalty_factor: decimal,
        min_deposit_size: wei_value
        ):

I do not have confidence, but I think that
your README might be lack of a parameter of null_sender.

zaq1tomo · 2018-06-06T06:28:09Z

e.g.

null_sender_address = base_tester.get_accounts()[-2]

casper_args = [
  EPOCH_LENGTH,
  WARM_UP_PERIOD,
  WITHDRAWAL_DELAY,
  DYNASTY_LOGOUT_DELAY,
  msg_hasher_address,
  purity_checker_address,
  null_sender_address,
  BASE_INTEREST_FACTOR,
  BASE_PENALTY_FACTOR,
  MIN_DEPOSIT_SIZE
]

djrtwo

Glad to see y'all made it through the deploy!

I generally want to be less verbose in the readme. The high level details are more important than the python specific implementation.

Take a look at my notes and let me know if you ahve any questions.

djrtwo · 2018-06-06T13:26:55Z

README.md

+In this example we will be using [eth-tester](https://github.com/ethereum/eth-tester).
+

+### Step 1: Imports


I want this to be way less system specific. Think, high level notes and a little bit of pseudocode. So we don't need to deal with imports

djrtwo · 2018-06-06T13:35:34Z

README.md

+
+### Step 2: Raise the Gas Limit
+
+```bash


Just note that the contract costs a lot of gas (can give a number) and that if they are deploying via a normal CREATE tx, then they need to make sure the block gas limit is high enough

djrtwo · 2018-06-06T13:36:18Z

README.md

+
+[Link to the web3.py documentation.](https://github.com/ethereum/web3.py)
+```bash
+base_tester = EthereumTester(PyEVMBackend())  ## instantiates the eth-test suite 


Just assume a web3 object exists. People will be deploying via all sorts of framekworks so the particulars here aren't important.

djrtwo · 2018-06-06T13:37:05Z

README.md

+
+### Step 4: Deploy Helper Contracts
+NOTE: In addition to the two helper contracts `msg_hasher` and `purity_checker` you also need to deploy the `rlp_decoder` Contract. On a production chain, an `rlp_decoder` contract is already deployed and vyper’s standard internal library knows it’s address and gives vyper contracts access to some functionality at that address.
+**When using a test chain, these helper contract must be deployed before the casper contract.**


Important to note that rlp_decoder must be deployed before compiling the casper contract.

djrtwo · 2018-06-06T13:40:03Z

README.md

+NOTE: In addition to the two helper contracts `msg_hasher` and `purity_checker` you also need to deploy the `rlp_decoder` Contract. On a production chain, an `rlp_decoder` contract is already deployed and vyper’s standard internal library knows it’s address and gives vyper contracts access to some functionality at that address.
+**When using a test chain, these helper contract must be deployed before the casper contract.**
+
+NOTE: these helper contracts are currently written in serpenat, so until they are converted to Vyper it is best to use the hardcoded transaction hex below. 


"These helper contracts can be deployed via the below pre-signed txs. Instructions for compiling and deploying via other methods will soon be available."

djrtwo · 2018-06-06T13:41:40Z

README.md

+### Step 6: Compiling and Deploying Casper
+```bash
+
+file = open(os.getcwd()+('/casper/contracts/simple_casper.v.py')) #this will change depending on where the casper contract is located relative to your current working directory


We should show how casper is compiled from the command line, rather than from python. Don't worry about showing how to open files.

vyper simple_casper.v.py vyper -f abi simple_casper.v.py

zaq1tomo · 2018-06-07T00:11:27Z

I am glad to receive your reply.

I understand your policy but your readme maybe incorrect.

zaq1tomo · 2018-06-07T00:12:44Z

README.md

+w3.eth.sendTransaction({'to': casper_address, 'value': 10**21})
+
+casper_contract = w3.eth.contract(address=casper_address, abi=casper_abi)
+casper_contract.functions.init(*casper_args).transact()


I think that it will not work with the latest version because casper_args is not correct.

Thank you for the hint. I will double check this issue.

zaq1tomo · 2018-06-07T00:15:22Z

I made a pull request to fix "casper_args".

GagziW#1

If you like, please refer it. Thanks.

Add null_sender to the params of init()

Readmedeploy

GagziW · 2018-06-11T23:14:35Z

@djrtwo I tried to incorporate your comments. Please review.

vs77bb · 2018-06-18T21:24:45Z

Hi @djrtwo I think this one might be with you for review, no? Hope you're doing well 🙂

GagziW added 3 commits May 31, 2018 16:49

updated the README to deploy a casper contract using eth-tester

005b7ae

fixed format and typos

9da4b7e

fixed more typos

96087dd

GagziW changed the title ~~[WIP] Adding casper deployment instruction to readme.md~~ [WIP] Adding casper deployment instruction to readme.md #152 Jun 1, 2018

GagziW mentioned this pull request Jun 3, 2018

Add vyper compiling instructions to README #152

Open

djrtwo suggested changes Jun 6, 2018

View reviewed changes

Add params to

40ecc01

zaq1tomo suggested changes Jun 7, 2018

View reviewed changes

GagziW and others added 9 commits June 7, 2018 19:29

part 1 modification

7591940

Merge pull request #1 from zaq1tomo/readmedeploy

9f11ddf

Add null_sender to the params of init()

merge conflict

b80a981

Rewriting the contract less verbose

370af00

modified readme

681fe95

minor syntax fixes

cd9e8d1

a few more minor semantic fixes

62c84b9

on last read over found a few more mistakes

ee0462d

Merge pull request #2 from williambannas/readmedeploy

645945c

Readmedeploy

		In this example we will be using [eth-tester](https://github.com/ethereum/eth-tester).


		### Step 1: Imports

Comments

Conversation

GagziW commented Jun 1, 2018

Uh oh!

zaq1tomo commented Jun 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zaq1tomo commented Jun 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

djrtwo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zaq1tomo commented Jun 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zaq1tomo commented Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GagziW commented Jun 11, 2018

Uh oh!

vs77bb commented Jun 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zaq1tomo commented Jun 6, 2018 •

edited

Loading

zaq1tomo commented Jun 6, 2018 •

edited

Loading

zaq1tomo commented Jun 7, 2018 •

edited

Loading