Skip to content

Conversation

juanchax
Copy link

Description

Updated external url references contained in /public/content/contributing/index.md to {variable}
Populated variables.ts with external url references contained in /public/content/contributing/index.md
Added preprocess.ts with the markdown preprocessing logic
Removed preprocessMarkdown() from compile.ts
Imported preprocessMarkdown() from preprocess.ts

Related Issue

Background for this enhabcement --> #15312

Base issues this enhancement is attempting to resolve and prevent future ones -->

#14605

#14200

#14711

juanchax and others added 3 commits April 20, 2025 15:22
Populated variables.ts with external url references contained in /public/content/contributing/index.md
Added preprocess.ts with the markdown preprocessing logic
Removed preprocessMarkdown() from compile.ts
imported preprocessMarkdown() from preprocess.ts
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project labels Apr 20, 2025
Copy link

netlify bot commented Apr 20, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1322fe0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/680674ffbbb7d500086ffac7
😎 Deploy Preview https://deploy-preview-15323--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🔴 down 3 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

added type guard for current escapeAnchorChars() implementation
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 22, 2025
@wackerow
Copy link
Member

wackerow commented Jul 9, 2025

Hey @juanchax! Appreciate the PR... I'm not sure this is really the approach we want to take here. It seems to add quite a bit of complexity?

Was the main point here so the URL's would stay consistent when used in other languages? cc: @pettinarip Curious your take here, but I'm concerned this would create more challenges than it would solve.

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 9, 2025
@juanchax
Copy link
Author

juanchax commented Jul 29, 2025

Hey @juanchax! Appreciate the PR... I'm not sure this is really the approach we want to take here. It seems to add quite a bit of complexity?

Was the main point here so the URL's would stay consistent when used in other languages? cc: @pettinarip Curious your take here, but I'm concerned this would create more challenges than it would solve.

Yeah, ok, a little background info here.
I noticed there are quite a few outdated links in translated pages, on top of the "bugs" related to dead links on several pages & translations that had already been reported.
Did some digging and found that the urls for the same link on a page might differ from one language to another, as in, they are hardcoded on pages.

So the overall refactor proposed might seem like a lot when looking at the effort I'd need to put in, but compared to having to regularly fish for dead + outdated links on all pages + all translation pages and go in and fix all instances "one-by-one", it's not that heavy a taask.

  • Moving away from hardcoded urls to url references,
  • keeping a config file as the one source of truth regarding urls for inks on pages,
  • still regularly check the configuration file for dead links but
  • update those references in the configuration file only.

Then, all pages across all languages will be automagically picking up the latest urls. If that makes sense(?)

PS. I'm offering to do the heavy lifting here, I just wanted to run it by you guys before going all in; specially to get some feedback and also to learn about possible planned refactors that would eliminate the need for this proposed PR.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants