-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[ Enhancement ] Adding Markdown preprocessor #15323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Populated variables.ts with external url references contained in /public/content/contributing/index.md Added preprocess.ts with the markdown preprocessing logic Removed preprocessMarkdown() from compile.ts imported preprocessMarkdown() from preprocess.ts
Adding Markdown preprocessor
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added type guard for current escapeAnchorChars() implementation
This issue is stale because it has been open 30 days with no activity. |
Hey @juanchax! Appreciate the PR... I'm not sure this is really the approach we want to take here. It seems to add quite a bit of complexity? Was the main point here so the URL's would stay consistent when used in other languages? cc: @pettinarip Curious your take here, but I'm concerned this would create more challenges than it would solve. |
Yeah, ok, a little background info here. So the overall refactor proposed might seem like a lot when looking at the effort I'd need to put in, but compared to having to regularly fish for dead + outdated links on all pages + all translation pages and go in and fix all instances "one-by-one", it's not that heavy a taask.
Then, all pages across all languages will be automagically picking up the latest urls. If that makes sense(?) PS. I'm offering to do the heavy lifting here, I just wanted to run it by you guys before going all in; specially to get some feedback and also to learn about possible planned refactors that would eliminate the need for this proposed PR. |
This issue is stale because it has been open 30 days with no activity. |
Description
Updated external url references contained in /public/content/contributing/index.md to {variable}
Populated variables.ts with external url references contained in /public/content/contributing/index.md
Added preprocess.ts with the markdown preprocessing logic
Removed preprocessMarkdown() from compile.ts
Imported preprocessMarkdown() from preprocess.ts
Related Issue
Background for this enhabcement --> #15312
Base issues this enhancement is attempting to resolve and prevent future ones -->
#14605
#14200
#14711