Rewrite new fork tool to modify blob parameters #1372
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1372 +/- ##
============================================
Coverage 94.94% 94.95%
============================================
Files 583 583
Lines 34665 34665
Branches 3070 3070
============================================
+ Hits 32914 32916 +2
+ Misses 1198 1195 -3
- Partials 553 554 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamWilsn
force-pushed
the
new-and-improved
branch
3 times, most recently
from
7909e08 to
ebd7090
Compare
|
|
||
| blob_parameters = parser.add_argument_group() | ||
|
|
||
| blob_parameters.add_argument( |
There was a problem hiding this comment.
This could get a bit more complicated since post-Osaka, we won't have TARGET_BLOB_GAS_PER_BLOCK as ain independent constant. See this
There was a problem hiding this comment.
Should we disable this option post-osaka or allow users to modify it at their own risk?
| options = parser.parse_args(args) | ||
|
|
||
| if options.template_fork == "spurious_dragon": | ||
| raise NotImplementedError( |
There was a problem hiding this comment.
Tangerine Whistle and Dao Fork?
There was a problem hiding this comment.
Ugh, if there are more instances of "a self-reference that shouldn't be changed" I don't think I can leave this unimplemented 🤣
There was a problem hiding this comment.
Hm, from a quick look, it seems like spurious dragon is the only fork that's referenced by other forks (eg. here).
SamWilsn
force-pushed
the
new-and-improved
branch
4 times, most recently
from
3e6785e to
615b3db
Compare
`actions-rs` has been archived and is no longer the recommended way to install packages. Instead, I'm using the Ubuntu-provided `rustup`.
SamWilsn
force-pushed
the
new-and-improved
branch
from
615b3db to
2347cb8
Compare
|
What a finicky tool. Should be good to review now. |
What was wrong?
Related to Issue #1357
How was it fixed?
Rewrote the new fork tool to be more than just find-and-replace. It now uses libcst to transform the source somewhat intelligently.
Cute Animal Picture