Skip to content

chore(execute): fix execute hive mode #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: forks/osaka
Choose a base branch
from
Open

chore(execute): fix execute hive mode #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/rpc/hive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,12 @@ def test_suite_description() -> str:
return "Execute EEST tests using hive endpoint."


@pytest.fixture(scope="function")
def test_case_description(request: pytest.FixtureRequest) -> str:
"""The description of the current test case for hive."""
return f"Test: {request.node.name}"
Comment on lines +238 to +241
Copy link
Member

@danceratopz danceratopz Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will return the test ID, not the test case description as expected by Hive. Is this necessary? Perhaps you're intentionally overwriting this fixture?

execution-specs/packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/execute_fill.py

Lines 183 to 205 in 15b5cfd

@pytest.fixture(scope="function")
def test_case_description(request: pytest.FixtureRequest) -> str:
"""
Fixture to extract and combine docstrings from the test class and the test
function.
"""
description_unavailable = "No description available - add a docstring to the python test class or function."
test_class_doc = ""
test_function_doc = ""
if hasattr(request.node, "cls"):
test_class_doc = (
f"Test class documentation:\n{request.cls.__doc__}"
if request.cls
else ""
)
if hasattr(request.node, "function"):
test_function_doc = (
f"{request.function.__doc__}" if request.function.__doc__ else ""
)
if not test_class_doc and not test_function_doc:
return description_unavailable
combined_docstring = f"{test_class_doc}\n\n{test_function_doc}".strip()
return combined_docstring



@pytest.fixture(autouse=True, scope="session")
def base_hive_test(
request: pytest.FixtureRequest,
Expand Down
5 changes: 4 additions & 1 deletion ...esting/src/execution_testing/cli/pytest_commands/pytest_ini_files/pytest-execute-hive.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ minversion = 7.0
python_files = *.py
testpaths = tests/
# Note: register new markers via src/execution_testing/cli/pytest_commands/plugins/shared/execute_fill.py
addopts =
addopts =
-p execution_testing.cli.pytest_commands.plugins.concurrency
-p execution_testing.cli.pytest_commands.plugins.execute.sender
-p execution_testing.cli.pytest_commands.plugins.execute.pre_alloc
Expand All @@ -19,3 +19,6 @@ addopts =
--tb short
--dist loadscope
--ignore tests/cancun/eip4844_blobs/point_evaluation_vectors/
# TODO: remove after https://github.com/ethereum/execution-specs/issues/1648
--ignore tests/json_infra
--ignore tests/evm_tools
Loading