-
Notifications
You must be signed in to change notification settings - Fork 372
fix(tests): optimize json_infra fixture reads #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: forks/osaka
Are you sure you want to change the base?
Conversation
* feat(tests): block rlp size limit eip-7934 test cases. Co-authored-by: Mario Vega <[email protected]> Co-authored-by: felipe <[email protected]> * fix: minor rename * Update tests/osaka/eip7934_block_rlp_limit/test_max_block_rlp_size.py Co-authored-by: felipe <[email protected]> * fix(tests): remove misleading block rlp cases --------- Co-authored-by: Mario Vega <[email protected]> Co-authored-by: felipe <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1730 +/- ##
============================================
Coverage 86.07% 86.07%
============================================
Files 743 743
Lines 44078 44078
Branches 3894 3894
============================================
Hits 37938 37938
Misses 5659 5659
Partials 481 481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented |
I saw! Was wondering if |
Ah. I see. From what I understand |
What was wrong?
Running the
json_infradoes a lot of I?O that can potentially be avoided.Related to Issue #
How was it fixed?
Optimise file reads from disk using some caching techniques and queueing the test fixtures in a better order.