Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Nov 3, 2025

πŸ—’οΈ Description

One legacy block validation check has been left uncovered, filling the gap.

Also I'm pulling in a bunch of missing exception mappers I've come across.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@pdobacz pdobacz force-pushed the tests/gaslimit-5000 branch 2 times, most recently from 66222f7 to 131daee Compare November 3, 2025 10:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.07%. Comparing base (9563a51) to head (118e40c).
⚠️ Report is 2 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1731   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481           
Flag Coverage Ξ”
unittests 86.07% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i do not know the frontier gas limit is so low: https://ethereum.stackexchange.com/questions/28486/why-is-block-gas-limit-set-to-5000

nit: maybe combine test_gas_limit_at_minimum & test_gas_limit_below_minimum but personally i think it is fine.

@pdobacz pdobacz force-pushed the tests/gaslimit-5000 branch from 131daee to 118e40c Compare November 4, 2025 06:41
@pdobacz
Copy link
Contributor Author

pdobacz commented Nov 4, 2025

nit: maybe combine test_gas_limit_at_minimum & test_gas_limit_below_minimum but personally i think it is fine.

I got complaints about @pytest.mark.exception_test, but I forgot I can use pytest.param with marks. Fixed now, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants