feat(tests): Add a case for RIPEMD OOGing in early forks #1732
+12
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
There was one aspect (the
0x03quirk) left uncovered in the RIPEMD test, and it turned out to be covered in static tests, so I guess this is a porting PR. I tried to follow the steps, but not 100% sure I did all the (currently) relevant steps.What makes me doubt it's complete is that the test exists (kinda) in
statictests (but only for>=Cancunforks) but also in https://github.com/ethereum/legacytests/blob/master/src/LegacyTests/Constantinople/GeneralStateTestsFiller/stPreCompiledContracts2/CallRipemd160_0Filler.json, I'm not exactly sure which should be put up there in the code. Nevertheless I'm removing the former one from here.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.@ported_frommarker.