Skip to content

chore(specs): refactor code deployment functions#2904

Open
SamWilsn wants to merge 1 commit into
ethereum:forks/amsterdamfrom
SamWilsn:deployable
Open

chore(specs): refactor code deployment functions#2904
SamWilsn wants to merge 1 commit into
ethereum:forks/amsterdamfrom
SamWilsn:deployable

Conversation

@SamWilsn
Copy link
Copy Markdown
Contributor

🗒️ Description

Combines account_has_code_or_nonce and account_has_storage into a single function, account_deployable.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 64.10256% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.36%. Comparing base (810c184) to head (f69d017).

Files with missing lines Patch % Lines
src/ethereum/forks/berlin/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
src/ethereum/forks/byzantium/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
src/ethereum/forks/constantinople/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
src/ethereum/forks/frontier/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
src/ethereum/forks/homestead/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
src/ethereum/forks/istanbul/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
src/ethereum/forks/london/state_tracker.py 33.33% 2 Missing and 2 partials ⚠️
...rc/ethereum/forks/berlin/vm/instructions/system.py 0.00% 0 Missing and 1 partial ⚠️
src/ethereum/forks/berlin/vm/interpreter.py 50.00% 0 Missing and 1 partial ⚠️
...ethereum/forks/byzantium/vm/instructions/system.py 0.00% 0 Missing and 1 partial ⚠️
... and 11 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2904      +/-   ##
===================================================
- Coverage            90.44%   90.36%   -0.08%     
===================================================
  Files                  535      535              
  Lines                32439    32478      +39     
  Branches              3012     3038      +26     
===================================================
+ Hits                 29338    29349      +11     
- Misses                2573     2587      +14     
- Partials               528      542      +14     
Flag Coverage Δ
unittests 90.36% <64.10%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant