-
Notifications
You must be signed in to change notification settings - Fork 32
manually backfill eip status history #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Observations that came to mind when implementing this PR:
|
wolovim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the lift!
focil did experience some whiplash, but ultimately the glamsterdam DFI + hegota CFI decision came in a package during acdc 171, so i've updated the statusHistory to that effect. also opportunistically updated a couple other stale eips while reviewing.
i'll address this separately, but when no dates/calls for any of the steps, i think a superior UX is to skip straight to only displaying the outcome in the timeline. e.g., proposed and scheduled steps are safe to assume based on context.
i hear you on TS autocompletion; the json choice is due to optimizing for easy contributions via github UI editing. my gut is that's still the right choice, but willing to debate it.
after looking at a few examples, yes that makes sense to me. 👍
given the few benefits i see, a downside in github UI editing as mentioned, and the scope/complexity of the change, i definitely don't propose a shift to TS files, at least for now. perhaps a debate for another day! |
Description
This PR manually backfills EIP status history. It backfills history so that we have the complete history from ACDE 223 to now. This is when we started to get the inclusion status process in place for Glamsterdam.
How to review this PR
You can review that we have complete history by comparing the Forkcast calls against the individual commits, using the table below. EIP-7805 (FOCIL) is included in the
acdc/171commit, but had history acrossacdc/170andacdc/171. You can also check the git history onmainif needed for additional context.mainEach commit describes the call it adds status history for. There is one exception which is EIP-7999, which was given a withdrawn status here. It does not appear to have happened in a call, and may have happened offline.
EIP-7805 (FOCIL) was a tricky one to piece together accurately, but should be correct based on the call history. Please review the proposed FOCIL status history.
The remaining two commits from activate pectra page d2278fe and scheduled -> included from fusaka activation should be self-explanatory by the commit message.