core: back-up to kvdb for a pruned block #31638
Open
+45
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/rawdb/accessors_chain.go
Outdated
| // The freezer might be pruned. In the particular case of genesis, the block | ||
| // will be still available in kvdb. The full genesis block is needed on startup | ||
| // sometimes for repair. | ||
| if data == nil { |
There was a problem hiding this comment.
should we only specialize the genesis block?
|
The alternative would be to relax the condition in var headBlock *types.Block
if headBlockNum == 0 {
header := bc.GetHeaderByHash(head)
headBlock = types.NewBlockWithHeader(header)
} else {
headBlock := bc.GetBlockByHash(head)
}
if headBlock == nil {
// Corrupt or empty database, init from scratch
log.Warn("Head block missing, resetting chain", "hash", head)
return bc.Reset()
}
``` |
|
I was trying to test this patch and hit this panic: |
|
Ok after fixing this I am now getting this repeated in my logs and it doesn't proceed: |
|
After adding the exception in SetHead: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #31601. I think what happens is the startup logic will try to get the full block body (it's
bc.loadLastState) and fail because genesis block has been pruned from the freezer. This will cause it to keep repeating the reset logic, causing a deadlock.This can happen when due to an unsuccessful sync we don't have the state for the head (or any other state) fully, and try to redo the snap sync.