core: record SetParentBeaconRoot beacon-root accesses in BAL#34897
Merged
jwasinger merged 1 commit intoMay 7, 2026
Merged
Conversation
Signed-off-by: Miroslav Kovář <miroslavkovar@protonmail.com>
jwasinger
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetParentBeaconRoot, which is used by hivechain block customization (modifyBlockpassed toGenerateChainasgen), runsProcessBeaconBlockRoot, but those accesses are not being recorded in BALs. Later,GenerateChainprocesses beacon root again with BAL tracking, so BAL could miss earlier mutations.This patch keeps current flow but records reads/writes from
SetParentBeaconRootinto the BAL when enabled. That fixes accounting mismatch without changing execution order.I tried to find a better solution which would avoid double beacon root processing but kept running into PMT root mismatches. This is the minimal working solution, and a temporary workaround to enable correct Amsterdam block generation anyway. Long-term we should move to a single canonical beacon-root processing path (or explicit idempotent handling) so execution and BAL accounting happen exactly once.
Used by ethereum/hive#1468 to enable Amsterdam block generation in hivechain.