-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain Evm Map #5313
Chain Evm Map #5313
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
10104bc
to
60b8861
Compare
I just tried switching in the Browser Wallet to Celo. But the change in network in the wallet did not get reflected in Deploy & Run. |
{ id: 42220, name: "Celo Mainnet" }, | ||
{ id: 42161, name: "Arbitrum One" }, | ||
{ id: 42170, name: "Arbitrum Nova" }, | ||
{ id: 44787, name: "Celo Alfajores Testnet" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Celo Alfajores Testnet should work with the latest EVM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
//show modal | ||
plugin.call('notification', 'modal', { | ||
id: 'evm-chainId-incompatible', | ||
title: 'Incompatible EVM - ChainId Detected', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update title to:
Incompatible EVM for the selected chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
id: 'evm-chainId-incompatible', | ||
title: 'Incompatible EVM - ChainId Detected', | ||
message: <div className="px-3"> | ||
<p>The selected chain is not compatible with the selected EVM version. Please select a one of the options below.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selected chain is not compatible with the EVM version that the Solidity contract had been compiled with. Please select a one of the options below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I have one last question - if the EVM chain map gets outdated - can someone still deploy to the chain - they just hit the cancel button and then they deploy anyway - right? |
The selected chain is not compatible with the EVM version that the Solidity contract had been compiled with. Please select a one of the options below. If there is time, please change the above sentence to: |
Done. Please check |
@joeizang we see a toaster about new settings which says "udapp is updating ..." Udapp is internal name and should be replaced by plugin Display name |
The rest looks LGTM |
14c2a1c
to
2300692
Compare
No description provided.