Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain Evm Map #5313

Merged
merged 24 commits into from
Nov 6, 2024
Merged

Chain Evm Map #5313

merged 24 commits into from
Nov 6, 2024

Conversation

joeizang
Copy link
Collaborator

No description provided.

@joeizang joeizang added the WIP label Oct 22, 2024
@joeizang joeizang self-assigned this Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 2300692
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/672b13d969033d0008f7db92
😎 Deploy Preview https://deploy-preview-5313--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang marked this pull request as draft October 23, 2024 08:56
@ryestew
Copy link
Collaborator

ryestew commented Oct 31, 2024

I just tried switching in the Browser Wallet to Celo. But the change in network in the wallet did not get reflected in Deploy & Run.

@joeizang joeizang marked this pull request as ready for review November 4, 2024 15:23
@joeizang joeizang requested review from LianaHus and ryestew November 4, 2024 15:23
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Nov 4, 2024
{ id: 42220, name: "Celo Mainnet" },
{ id: 42161, name: "Arbitrum One" },
{ id: 42170, name: "Arbitrum Nova" },
{ id: 44787, name: "Celo Alfajores Testnet" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Celo Alfajores Testnet should work with the latest EVM.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

//show modal
plugin.call('notification', 'modal', {
id: 'evm-chainId-incompatible',
title: 'Incompatible EVM - ChainId Detected',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update title to:
Incompatible EVM for the selected chain

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

id: 'evm-chainId-incompatible',
title: 'Incompatible EVM - ChainId Detected',
message: <div className="px-3">
<p>The selected chain is not compatible with the selected EVM version. Please select a one of the options below.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selected chain is not compatible with the EVM version that the Solidity contract had been compiled with. Please select a one of the options below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ryestew
Copy link
Collaborator

ryestew commented Nov 4, 2024

Strangely when I tried 1st to deploy to Celo Alfajores, I got this out of gas error:
image

Then when I tried again I got the warning in this PR:
image

@joeizang
Copy link
Collaborator Author

joeizang commented Nov 4, 2024

Strangely when I tried 1st to deploy to Celo Alfajores, I got this out of gas error: image

Then when I tried again I got the warning in this PR: image

I am not sure about the gas error though.

@ryestew
Copy link
Collaborator

ryestew commented Nov 5, 2024

I have one last question - if the EVM chain map gets outdated - can someone still deploy to the chain - they just hit the cancel button and then they deploy anyway - right?

@ryestew
Copy link
Collaborator

ryestew commented Nov 5, 2024

There is something weird with the modals - I tried to deploy to Celo mainnet and I got 2 modals - the first disappeared to fast to see it and the second was the old modal:
image

But this modal (above) is the one that should be suppressed - I mean the modal we worked on should appear and if the file is recompiled with a different VM the modal above should not appear (because it will just work). If they hit cancel on the modal we worked on and the EVM list is correct, this second modal will appear.

Something similar happens when I load this deployed instance - both entry modals appear and disappear (or is there only 1 - sometime there are 2) - but anyway - I can't accept anything - the entry modals go away and the site loads. So will the matomo modal load and wait for an answer?

@joeizang joeizang requested a review from ryestew November 5, 2024 10:29
@ryestew
Copy link
Collaborator

ryestew commented Nov 5, 2024

The selected chain is not compatible with the EVM version that the Solidity contract had been compiled with. Please select a one of the options below.

If there is time, please change the above sentence to:
The smart contract has not been compiled with an EVM version that is compatible with the selected chain.

@joeizang
Copy link
Collaborator Author

joeizang commented Nov 5, 2024

The smart contract has not been compiled with an EVM version that is compatible with the selected chain.

Done. Please check

@LianaHus
Copy link
Collaborator

LianaHus commented Nov 5, 2024

@joeizang we see a toaster about new settings which says "udapp is updating ..." Udapp is internal name and should be replaced by plugin Display name

@LianaHus
Copy link
Collaborator

LianaHus commented Nov 5, 2024

The rest looks LGTM

@Aniket-Engg Aniket-Engg merged commit dbf1088 into master Nov 6, 2024
30 checks passed
@Aniket-Engg Aniket-Engg deleted the evmver-chainid-map branch November 6, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants