feat: improve error handling in TraceManager with TraceError class #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
yann300
reviewed
Jan 20, 2025
| } | ||
| throw new TraceError('No stack data found for the given step index', stepIndex) |
There was a problem hiding this comment.
I think this needs to be in a else statement.
There was a problem hiding this comment.
@yann300 made an update, and also provided a similar change to another place in code. Does it seem alright to you?
|
Closing that one as we are planning for a refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Benefits: