E2E TESTS for solc compiler sha256 checksum #141
Conversation
|
hello, I checked your script and found an issue: in calculate-sha256-checksum() {
file_path="${1}"
sha256sum "${path}" | awk '{ print $1 }'
}fails shellcheck with error: $ shellcheck
file_path appears unused. Verify use (or export if used externally).shellcheck[SC2034](https://www.shellcheck.net/wiki/SC2034)fixing it to just However, I am not entirely sure that is the reason, it could also be how the function is implemented calculate-sha256-checksum() {
path="${1}"
checksum=$(sha256sum "${path}")
echo "${checksum}" | awk '{ print $1 }'
}if we invoke the sha256sum command separately, we can use its output in the checksum variable using command substitution via checksum$(). Thank you for taking the time to do such checks. There have been instances in which the produced artifact checksum was invalid over the years. The latest such instance being, 0.8.25 (yes the latest release). Here is the output of the sync-compilers.log for your verification: https://gist.github.com/sambacha/fd41c326aedc0d844397f30ceab0ff10 |
This PR presents E2E solution to bring to light solc compiler versions which appear to fail checksum verification in terms of matching the data in each
builds[].sha256field in (URL: https://binaries.soliditylang.org/bin/list.json)Excerpt from
sync-compilers.log