feat: implement eth_call and refactor trin-execution to support async db #1415
Conversation
|
@KolbyML , would like your early feedback on this PR, especially on the work in Note: I didn't test if this actually works, as I don't have data in the state network to test it with. I will have to manually create and seed data needed but it's not simple as I have to seed many trie nodes, for multiple accounts and storage slots (and at least one contract bytecode). Other than testing, I would say that this PR is mostly ready as is. |
There was a problem hiding this comment.
You asked for some early feedback, some it it looks fine. My main concern is this PR cements and creates abstractions for bad practices, this PR is based off latest which doesn't contain the improvements from #1337 yet.
This PR builds off of master which still calls EvmBuilder for every transaction which isn't idle. So my main feedback is to build off #1337
| /// Executes the transaction with external context in the blocking manner. | ||
| pub fn execute_transaction_with_external_context< | ||
| DB: DatabaseRef, | ||
| EXT: GetInspector<WrapDatabaseRef<DB>>, | ||
| >( | ||
| tx: &impl TxEnvModifier, | ||
| evm_environment: Env, | ||
| external_context: EXT, | ||
| database: DB, | ||
| ) -> EVMResult<DB::Error> { | ||
| let block_number = evm_environment.block.number.to::<u64>(); | ||
| Evm::builder() | ||
| .with_ref_db(database) | ||
| .with_env(Box::new(evm_environment)) | ||
| .with_spec_id(get_spec_id(block_number)) | ||
| .modify_tx_env(|tx_env| tx.modify(block_number, tx_env)) | ||
| .with_external_context(external_context) | ||
| .append_handler_register(inspector_handle_register) | ||
| .build() | ||
| .transact() | ||
| } |
|
Closing in favor of #1439 |
What was wrong?
The
eth_callwasn't supported.How was it fixed?
Refactored logic in trin-execution crate to make functionality more reusable (and added support for async database).
Also refactored
rpc/src/eth_rpc.rsby extracting state related functionality into separate file.To-Do