-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monorepo: upgrade typescript beyond v5 #3610
Draft
gabrocheleau
wants to merge
13
commits into
master
Choose a base branch
from
monorepo/upgrade-typescript-latest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrocheleau
added
package: monorepo
dependencies
Pull requests that update a dependency file
type: maintenance
labels
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades TypeScript to 5.5.4 and makes the necessary adjustments so that the monorepo builds.
This PR also makes some related adjustments to the monorepo dependencies, as some of the dependencies were not compatile with the updated TypeScript version (the two
@typescript-eslint
ones). This led to peer dependency issues with the"eslint-config-typestrict": "^1.0.5"
, and since there seems to be no updaed version of that package (I can't find anything on it actually strangely?), I removed it altogether.One linting error that I have not yet been able to fix:
(Edit: finally fixed by adding paths in some places in the tsconfigs, leaving this here for reference:).
There is one outstanding build error that I have yet to fix: