feature: Midas Liquid Reserve Vault Support #85

shinchann221 · 2025-12-30T21:53:10Z

Add Midas Vault Integration Module

Summary

Adds MidasModule to enable EtherFi Safes to interact with Midas Liquid Reserve Vaults. Supports multiple vaults, depositing USDC/USDT to mint Midas tokens, instant withdrawals, and async withdrawals via Cash Module integration.

Changes

MidasModule.sol: Module contract supporting multiple Midas vaults with:
- Deposit/withdraw operations for any configured Midas token
- Admin functions to add/remove vaults and supported assets (requires MIDAS_MODULE_ADMIN role)
- Signature-based authorization for all operations
- Dynamic decimal scaling between assets
- Async withdrawal integration with Cash Module
- Reentrancy protection
IMidasVault.sol: Interface for Midas Vault operations (depositInstant, redeemInstant, redeemRequest)
DeployMidasModule.s.sol: Deployment script that configures module, price oracle, collateral settings (90% LTV, 95% liquidation threshold), and withdrawable assets
scripts/gnosis-txs/DeployMidasModule.s.sol: Gnosis Safe deployment script for Midas module
scripts/gnosis-txs/SetMidasConfig.s.sol: Gnosis Safe configuration script that sets up module permissions, price oracle, collateral/borrow config, and withdrawable assets
MidasModule.t.sol: Comprehensive test suite covering deposits, withdrawals, async flows, multi-vault scenarios, and error cases

Files Changed

src/modules/midas/MidasModule.sol (new)
src/interfaces/IMidasVault.sol (new)
scripts/DeployMidasModule.s.sol (new)
scripts/gnosis-txs/DeployMidasModule.s.sol (new)
scripts/gnosis-txs/SetMidasConfig.s.sol (new)
test/safe/modules/midas/MidasModule.t.sol (new)
remappings.txt (new)
deployments/dev/534352/deployments.json (modified)
foundry.toml (modified)

certora-run

Verification Results

Group ID: 6b7fb3fe-6efa-454d-bbc5-7e6c6bba3a6c

Job	Result	VERIFIED	Link
EtherFiSafe.conf	⌛	0	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

shivam-ef · 2025-12-31T16:12:57Z

scripts/DeployMidasModule.s.sol

+        //price provider set oracle
+        PriceProvider(priceProvider).setTokenConfig(tokens, midasConfigs);
+
+        IDebtManager.CollateralTokenConfig memory collateralConfig = IDebtManager.CollateralTokenConfig({ ltv: 90e18, liquidationThreshold: 95e18, liquidationBonus: 1e18 });


Check with Chaos for config

I've put a message

scripts/DeployMidasModule.s.sol

src/modules/midas/MidasModule.sol

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8c8f91ba9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/modules/midas/MidasModule.sol

certora-run

Verification Results

Group ID: 7b72f814-7c25-46ab-803f-745badff75e9

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

certora-run

Verification Results

Group ID: 959d9742-ce99-4b04-a528-fa4afb0d59ae

Job	Result	VERIFIED	Link
EtherFiSafe.conf	⌛	0	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

src/modules/midas/MidasModule.sol

certora-run

Verification Results

Group ID: 464c73b1-15d7-4501-a6f6-287a6b2bd103

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

shinchann221 · 2026-01-08T16:11:42Z

Audit Changes - MidasModule

Commit: 9daccfb - feat: changed withdraw implementation and fixed audit issues

Summary

This commit simplifies the MidasModule by removing the async withdrawal flow and switching to a direct async withdrawal request pattern. The module now directly calls redeemRequest on the Midas vault instead of managing withdrawal state internally.

Major Changes

1. Withdrawal Implementation Simplified

Removed Functions:

requestWithdrawal() - Removed async withdrawal request function
executeWithdraw() - Removed async withdrawal execution function
getPendingWithdrawal() - Removed function to retrieve pending withdrawals
_requestAsyncWithdraw() - Removed internal async withdrawal request logic
_executeWithdraw() - Removed internal async withdrawal execution logic
_getRequestWithdrawDigestHash() - Removed digest hash function for async withdrawals

Modified Function:

withdraw() - Now directly calls redeemRequest instead of redeemInstant
- Removed parameter: minReceiveAmount (uint256)
- Changed behavior: Creates async withdrawal request via IMidasVault.redeemRequest() instead of synchronous redeemInstant()
- Updated documentation: Clarifies that withdrawal completion is handled by the Midas vault

Impact:

Withdrawals are now fully async - the Midas vault handles completion
No internal state tracking for pending withdrawals
No integration with CashModule's withdrawal delay system
Simpler codebase with reduced attack surface

2. Removed State Variables and Structs

Removed: AsyncWithdrawal struct
Removed: withdrawals mapping (tracked pending withdrawals per Safe)
Removed: REQUEST_WITHDRAW_SIG constant

3. Removed Errors

NoWithdrawalQueued() - No longer needed without async withdrawal tracking
CannotFindMatchingWithdrawalForSafe() - No longer needed without async withdrawal tracking
UnsupportedAsset() - Was defined but never used

4. Added Error

InvalidDecimals() - Added validation in _scaleAmount() to ensure token decimals don't exceed 18

5. Event Changes

Removed Events:

WithdrawalRequested(address indexed safe, uint256 amount, address asset, address midasToken)
WithdrawalExecuted(address indexed safe, uint256 amount, address asset, address midasToken)

Modified Event:

Withdrawal - Changed signature from:

// Old
event Withdrawal(address indexed safe, address indexed inputToken, uint256 inputAmount, address indexed outputToken, uint256 outputAmount);

// New
event Withdrawal(address indexed safe, uint256 amount, address asset, address midasToken);

6. Code Quality Improvements

Removed Unused Imports:

WithdrawalRequest from ICashModule.sol
SafeCast usage (import remains but using statement removed)

Documentation Updates:

Updated withdraw() documentation to clarify async behavior
Removed references to UnsupportedAsset error
Fixed parameter documentation in _deposit() (clarified amount is in asset decimals, not midasToken decimals)
Added @custom:throws InvalidDecimals documentation

Constructor Changes:

Removed redundant _etherFiDataProvider == address(0) check (already handled by ModuleBase)

Testing Updates

All test cases related to async withdrawal flows have been removed:

test_requestWithdrawAndExecuteWithdraw_success
test_requestWithdrawal_createsWithdrawal
test_requestWithdrawal_executesWithdrawal_whenTheWithdrawDelayIsZero
test_executeWithdrawal_reverts_ifWithdrawalDelayIsNotOver
test_executeWithdrawal_reverts_whenNoWithdrawalQueued
test_requestWithdrawal_insufficientAmount
test_requestAsyncWithdrawal_invalidInput
test_requestWithdrawal_revertsWithUnsupportedMidasToken
test_getPendingWithdrawal_returnsCorrectData
test_getPendingWithdrawal_returnsEmptyWhenNoWithdrawal

All withdraw() tests updated to:

Remove minReceiveAmount parameter
Update event expectations
Remove return amount assertions (async completion handled by vault)

Files Changed

src/modules/midas/MidasModule.sol - Core implementation changes
test/safe/modules/midas/MidasModule.t.sol - Test updates to match new implementation

certora-run

Verification Results

Group ID: 9b30e6fe-5111-4e6b-91ac-05a7795d4476

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

certora-run

Verification Results

Group ID: 0bee659b-a8ee-4ae4-a785-4246bf2bc90e

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

scripts/gnosis-txs/SetMidasConfig.s.sol

certora-run

Verification Results

Group ID: caa39c34-e1e3-472a-aa6c-bfe22cb85f92
Commit: 4bea39a

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

certora-run

Verification Results

Group ID: a5c2a7b5-88aa-44be-af79-ff378d8a4362
Commit: 5add4bc

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

certora-run

Verification Results

Group ID: 3b385b85-1663-4a4e-abb3-599d5ecc5f6b
Commit: bcc68a4

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

certora-run

Verification Results

Group ID: 97739c3d-c347-481f-8609-db31c6d2f3ff
Commit: 0e43e58

Job	Result	VERIFIED	Link
EtherFiSafe.conf	⌛	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

certora-run

Verification Results

Group ID: 881355cf-d842-4dec-b3d9-dab1960cc5dd
Commit: 17031fe

Job	Result	VERIFIED	Link
EtherFiSafe.conf	✅	14	Link
CashModuleCore.conf --rule "p03"	✅	2	Link

fixed

shinchann221 added 3 commits December 29, 2025 14:49

created Midas Vault contract

a1e7f43

Midas deploy script

edeb630

added test cases

0792f60

shinchann221 requested a review from shivam-ef December 30, 2025 21:53

certora-run bot reviewed Dec 30, 2025

View reviewed changes

shivam-ef reviewed Dec 31, 2025

View reviewed changes

updated module to support multiple vaults

e8c8f91

shinchann221 marked this pull request as ready for review January 2, 2026 21:13

chatgpt-codex-connector bot reviewed Jan 2, 2026

View reviewed changes

src/modules/midas/MidasModule.sol Outdated Show resolved Hide resolved

certora-run bot reviewed Jan 2, 2026

View reviewed changes

fix: added recipient for async withdraw

3e74b57

certora-run bot reviewed Jan 2, 2026

View reviewed changes

shivam-ef previously requested changes Jan 2, 2026

View reviewed changes

src/modules/midas/MidasModule.sol Outdated Show resolved Hide resolved

src/modules/midas/MidasModule.sol Show resolved Hide resolved

src/modules/midas/MidasModule.sol Outdated Show resolved Hide resolved

removed supportedAssets

a7ce4d7

certora-run bot reviewed Jan 2, 2026

View reviewed changes

feat: changed withdraw implementation and fixed audit issues

9daccfb

certora-run bot reviewed Jan 8, 2026

View reviewed changes

shinchann221 added 3 commits January 8, 2026 13:43

deploy: midas module on dev

e58fb30

feat: create midas deploy & set config script

76624f7

Merge branch 'master' into feature/midas-support

568984a

certora-run bot reviewed Jan 13, 2026

View reviewed changes

shivam-ef reviewed Jan 15, 2026

View reviewed changes

scripts/gnosis-txs/SetMidasConfig.s.sol Outdated Show resolved Hide resolved

scripts/gnosis-txs/SetMidasConfig.s.sol Outdated Show resolved Hide resolved

changed staleness threshold to 6 days

4bea39a

certora-run bot reviewed Jan 15, 2026

View reviewed changes

deploy: midas module prod

5add4bc

certora-run bot reviewed Jan 15, 2026

View reviewed changes

shinchann221 added 2 commits January 15, 2026 16:46

feat: generated midas config 3cp output

f3022fb

feat: updated collateral config

bcc68a4

certora-run bot reviewed Jan 15, 2026

View reviewed changes

verify bytecode

0e43e58

certora-run bot reviewed Jan 15, 2026

View reviewed changes

fix: test cases

17031fe

certora-run bot reviewed Jan 16, 2026

View reviewed changes

feature: Midas Liquid Reserve Vault Support #85

Are you sure you want to change the base?

feature: Midas Liquid Reserve Vault Support #85

Uh oh!

Conversation

shinchann221 commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Midas Vault Integration Module

Summary

Changes

Files Changed

Uh oh!

certora-run bot left a comment

Choose a reason for hiding this comment

Verification Results

Uh oh!

shivam-ef Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

shinchann221 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

certora-run bot left a comment

Choose a reason for hiding this comment

Verification Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

shinchann221 commented Jan 8, 2026

Audit Changes - MidasModule

Summary

Major Changes

1. Withdrawal Implementation Simplified

Removed Functions:

Modified Function:

Impact:

2. Removed State Variables and Structs

3. Removed Errors

4. Added Error

5. Event Changes

Removed Events:

Modified Event:

6. Code Quality Improvements

Removed Unused Imports:

Documentation Updates:

Constructor Changes:

Testing Updates

Files Changed

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

certora-run bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Verification Results

Uh oh!

Uh oh!

Uh oh!

shinchann221 commented Dec 30, 2025 •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading

certora-run bot left a comment •

edited

Loading