Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add resource type parameter to init and shutdown resources using specialized providers #858

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature: Add resource type parameter to init and shutdown resources using specialized providers #858

wants to merge 3 commits into from

Conversation

amoncusir
Copy link

@amoncusir amoncusir commented Feb 21, 2025 •
edited
Loading

Objective

Enable the initialization and shutdown of resources by specifying their type. This allows you to create logical groups of resources and handle them by type, similar to applying resource scoping.

Changes

  • New Argument: Added an optional argument to both Container.init_resources and Container.shutdown_resources to specify which resource type(s) should be processed.
  • Tests: Added tests to ensure that resource scoping works correctly, including scenarios where dependent resources belong to different types.
  • Docs: Added documentation on resource to explain how can be used

@amoncusir
feat: Add resource_type argument on init_resources and `shutdown_re…
6f4d23c 
…sources` methods to provide a more granular way to initialize the desired resources and add the possibility to scope that ones.
@amoncusir
feat: Add testing specifying the resource type creating scoping resou…
a3727aa 
…rces.
@amoncusir amoncusir mentioned this pull request Feb 22, 2025
Open
@amoncusir
feat(docs): Added documentation about how to use the init_resources a…
15c0b00 
…nd shutdown_resources using the resource_type argument and how can scope the resources
@amoncusir amoncusir marked this pull request as ready for review February 22, 2025 18:51
colo-o
colo-o approved these changes Feb 24, 2025
View reviewed changes
Copy link

@colo-o colo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colo-o colo-o colo-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amoncusir @colo-o