Fixed tariff: fix sorting zones with deviating months or days #26425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evcc-bot
added
enhancement
andig
reviewed
Jan 5, 2026
andig
reviewed
Jan 5, 2026
| }{ | ||
| // REVERSED: specific first, general second | ||
| // Without MoreSpecific, this will fail! | ||
| {0.10, "0-5", "Jan-Mar,Oct-Dec"}, // specific (winter only) |
Member
There was a problem hiding this comment.
Am Ende müssen vmtl. auch Überlappungen gehandhabt werden? In jedem Fall wäre es schön diese- wenn nicht vergleichbar- als Fehler identifizieren zu können.
Contributor
Author
There was a problem hiding this comment.
aber nur wenn wirklich "ambigious"? Das braucht ein paar Helper
andig
reviewed
Jan 5, 2026
This reverts commit 3794bef.
Contributor
Author
|
test fails since logging |
iseeberg79
commented
Jan 10, 2026
Comment on lines
+81
to
+85
| // Sort markers by time to ensure correct ordering | ||
| slices.SortFunc(res, func(a, b HourMin) int { | ||
| return a.Minutes() - b.Minutes() | ||
| }) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
major required fix - paired with correcting rates clock
iseeberg79
commented
Jan 10, 2026
| var res api.Rates | ||
|
|
||
| start := now.With(t.clock.Now().Local()).BeginningOfDay() | ||
| start := now.With(t.clock.Now()).BeginningOfDay() |
Contributor
Author
There was a problem hiding this comment.
required, fix clock dependencies
Contributor
Author
|
@andig PR consists of two parts, one fixes a missing sorting and adresses the issue directly - the second parts features overlapping, etc.. Commented them to mark required changes; others enhance robustness. Perhaps slit the PR in fix and features, wdyt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26164, includes #26413
adds