Skip to content

Conversation

@andig
Copy link
Member

@andig andig commented Jan 18, 2026

Fix #26409

@andig andig added the heating Heating label Jan 18, 2026
@andig andig enabled auto-merge (squash) January 18, 2026 18:06
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `templates/definition/charger/xtherma.yaml:12-14` </location>
<code_context>
+params:
+  - name: modbus
+    choice: ["tcpip"]
+  - name: tempsource
+    type: choice
+    choice: ["warmwater", "buffer"]
+render: |
+  type: heatpump
</code_context>

<issue_to_address>
**issue:** The `tempsource` parameter is defined but not used in the rendered config.

Since changing `tempsource` currently has no effect, either wire it into the template logic (e.g., conditionally select different `temp`/`limittemp` registers or scaling based on its value) or remove it until it’s actually used to avoid confusing users.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig disabled auto-merge January 18, 2026 18:08
Copy link

@55Jojo2024 55Jojo2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to properly test this yet, the sun isnt shining, but these are my findings so far.

type: input
encoding: int32
scale: 10
limittemp:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be templimit instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you guessing or did you actually test this? See https://github.com/evcc-io/evcc/blob/master/charger/measurement/heating.go#L10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @55Jojo2024 did you test this?

@github-actions github-actions bot added the stale Outdated and ready to close label Jan 25, 2026
@github-actions github-actions bot removed the stale Outdated and ready to close label Jan 29, 2026
@andig andig enabled auto-merge (squash) January 29, 2026 14:02
@andig andig changed the title Add Xtherma heatpump Add Xtherma heatpump (experimental) Jan 29, 2026
@andig andig merged commit ccd0857 into master Jan 29, 2026
13 checks passed
@andig andig deleted the feat/xtherma branch January 29, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

heating Heating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XTherma Wärmepumpe

3 participants